third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp - Issue 1817323003: Revert of Remove create/delete methods from WebGraphicsContext3D.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

Issue 1817323003: Revert of Remove create/delete methods from WebGraphicsContext3D. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@complex-casts

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLQuery.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

index 43d538be9efd10d05234f0b1b1bf684409ec5d37..86ebce7910d25b1b4632e6fa32192ef3a61012f8 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

@@ -201,12 +201,11 @@

WebGLFramebuffer::WebGLFramebuffer(WebGLRenderingContextBase* ctx)

: WebGLContextObject(ctx)

- , m_object(0)

+ , m_object(ctx->webContext()->createFramebuffer())

, m_destructionInProgress(false)

, m_hasEverBeenBound(false)

, m_readBuffer(GL_COLOR_ATTACHMENT0)

{

- ctx->contextGL()->GenFramebuffers(1, &m_object);

}

WebGLFramebuffer::~WebGLFramebuffer()

@@ -368,7 +367,7 @@

attachment.value->onDetached(context3d, gl);

}

- gl->DeleteFramebuffers(1, &m_object);

+ context3d->deleteFramebuffer(m_object);

m_object = 0;

}