Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1817323002: Make most of content/common pass gn check (Closed)

Created:
4 years, 9 months ago by brettw
Modified:
4 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make most of content/common pass gn check This fixes all but one bug in content/common. That bug is filed separately as: BUG=596736 Committed: https://crrev.com/6334088eca79889051fd0abb44033d80d5d24c7d Cr-Commit-Position: refs/heads/master@{#382591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M content/common/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/BUILD.gn View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817323002/1
4 years, 9 months ago (2016-03-22 00:07:40 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 01:17:42 UTC) #4
brettw
4 years, 9 months ago (2016-03-22 16:45:48 UTC) #6
jam
lgtm
4 years, 9 months ago (2016-03-22 17:03:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817323002/1
4 years, 9 months ago (2016-03-22 17:04:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 17:09:59 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 17:11:25 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6334088eca79889051fd0abb44033d80d5d24c7d
Cr-Commit-Position: refs/heads/master@{#382591}

Powered by Google App Engine
This is Rietveld 408576698