Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Unified Diff: mojo/public/c/system/message_pipe.h

Issue 1817303002: Update comments in system headers to include MOJO_RESULT_BUSY behavior. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/c/system/data_pipe.h ('k') | mojo/public/c/system/wait.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/c/system/message_pipe.h
diff --git a/mojo/public/c/system/message_pipe.h b/mojo/public/c/system/message_pipe.h
index 809d7579797860e33a4e971a111fa8e57cf19357..cc57d8cd26a75eebf2feba09102b375292ccc25f 100644
--- a/mojo/public/c/system/message_pipe.h
+++ b/mojo/public/c/system/message_pipe.h
@@ -102,7 +102,10 @@ MojoResult MojoCreateMessagePipe(
// across processes), so this function may succeed even if the other
// endpoint has been closed (in which case the message would be dropped).
// |MOJO_RESULT_UNIMPLEMENTED| if an unsupported flag was set in |*options|.
-// |MOJO_RESULT_BUSY| if some handle to be sent is currently in use.
+// |MOJO_RESULT_BUSY| if |message_pipe_handle| is currently in use in some
+// transaction (that, e.g., may result in it being invalidated, such as
+// being sent in a message), or if some handle to be sent is currently in
+// use.
//
// TODO(vtl): Add a notion of capacity for message pipes, and return
// |MOJO_RESULT_SHOULD_WAIT| if the message pipe is full.
@@ -141,6 +144,9 @@ MojoResult MojoWriteMessage(MojoHandle message_pipe_handle, // In.
// provided buffer(s). The message will have been left in the queue or
// discarded, depending on flags.
// |MOJO_RESULT_SHOULD_WAIT| if no message was available to be read.
+// |MOJO_RESULT_BUSY| if |message_pipe_handle| is currently in use in some
+// transaction (that, e.g., may result in it being invalidated, such as
+// being sent in a message).
//
// TODO(vtl): Reconsider the |MOJO_RESULT_RESOURCE_EXHAUSTED| error code; should
// distinguish this from the hitting-system-limits case.
« no previous file with comments | « mojo/public/c/system/data_pipe.h ('k') | mojo/public/c/system/wait.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698