Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scm.py

Issue 18173003: Replace --no-pager with GIT_PAGER=cat (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« git_cl.py ('K') | « git_cl.py ('k') | tests/git_cl_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scm.py
diff --git a/scm.py b/scm.py
index 7293f83348c2ffd7902492aa5e815c386f897e78..ca7fa3c7abf907335954e19ae69ca37932c985fa 100644
--- a/scm.py
+++ b/scm.py
@@ -98,9 +98,11 @@ class GIT(object):
@staticmethod
def Capture(args, cwd, **kwargs):
+ env = os.environ
M-A Ruel 2013/07/08 19:10:50 same
+ env['GIT_PAGER'] = 'cat' # Magical string that disables pagers.
return subprocess2.check_output(
- ['git', '--no-pager'] + args,
- cwd=cwd, stderr=subprocess2.PIPE, **kwargs)
+ ['git'] + args,
+ cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs)
@staticmethod
def CaptureStatus(files, cwd, upstream_branch):
« git_cl.py ('K') | « git_cl.py ('k') | tests/git_cl_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698