Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1817283002: Make predefined character table slightly smaller. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make predefined character table slightly smaller. Add a few missing consts and remove a few extra externs. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d074e9787fe5f21d49269a504969cfcf4eec016b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -153 lines) Patch
M core/fpdfapi/fpdf_font/font_int.h View 3 chunks +19 lines, -15 lines 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/doc_action.cpp View 3 chunks +33 lines, -25 lines 0 comments Download
M core/fpdfdoc/doc_basic.cpp View 2 chunks +16 lines, -9 lines 0 comments Download
M core/include/fpdfapi/fpdf_resource.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.cpp View 2 chunks +100 lines, -96 lines 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.cpp View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
Oliver, for review.
4 years, 9 months ago (2016-03-21 22:31:30 UTC) #3
Oliver Chang
lgtm
4 years, 9 months ago (2016-03-21 22:51:47 UTC) #4
Tom Sepez
4 years, 9 months ago (2016-03-21 22:53:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d074e9787fe5f21d49269a504969cfcf4eec016b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698