Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6926)

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

Issue 1817263003: Allow TimeTicks for serialized page load operations to be equal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add param Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
index 4c101f6009c02663d45ae3a1f911a2ca88a14461..8d0b11c47db55c5e616a47c08e7fbdf161a3ba3c 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
@@ -129,13 +129,14 @@ void AbortsPageLoadMetricsObserver::OnComplete(
return;
base::TimeDelta time_to_abort = extra_info.time_to_abort;
- DCHECK(!time_to_abort.is_zero());
// Don't log abort times if the page was backgrounded before the abort event.
- if (!WasStartedInForegroundEventInForeground(time_to_abort, extra_info))
+ // time_to_abort might be zero but it is known this is valid otherwise
+ // abort_type would be ABORT_NONE, so pass true for event_was_committed.
+ if (!WasStartedInForegroundEventInForeground(time_to_abort, true, extra_info))
return;
- if (extra_info.time_to_commit.is_zero()) {
+ if (!extra_info.committed) {
RecordAbortBeforeCommit(abort_type, time_to_abort);
return;
}
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698