Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1817233002: Temporarily disable all calls of CGS private APIs. (Closed)

Created:
4 years, 9 months ago by erikchen
Modified:
4 years, 9 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily disable all calls of CGS private APIs. This will allow us to confirm whether they are responsible for Window Server crashes on VMs. BUG=515627 Committed: https://crrev.com/c78367235e513da2c1745785e93c1d085a07de9f Cr-Commit-Position: refs/heads/master@{#382415}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Compile errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -75 lines) Patch
M ui/base/cocoa/constrained_window/constrained_window_animation.mm View 1 2 chunks +78 lines, -72 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget.mm View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
erikchen
tapted: Please review.
4 years, 9 months ago (2016-03-21 19:14:57 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817233002/1
4 years, 9 months ago (2016-03-21 19:15:28 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/176039)
4 years, 9 months ago (2016-03-21 19:26:07 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817233002/20001
4 years, 9 months ago (2016-03-21 19:35:21 UTC) #8
tapted
Lgtm. Feel free to tbr me on stuff that brings parts back. And let me ...
4 years, 9 months ago (2016-03-21 19:41:04 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-21 20:17:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817233002/20001
4 years, 9 months ago (2016-03-21 21:42:30 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 22:19:04 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c78367235e513da2c1745785e93c1d085a07de9f Cr-Commit-Position: refs/heads/master@{#382415}
4 years, 9 months ago (2016-03-21 22:20:25 UTC) #16
erikchen
4 years, 8 months ago (2016-04-04 21:44:23 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1853373002/ by erikchen@chromium.org.

The reason for reverting is: Still seeing Window Server crashes:

https://bugs.chromium.org/p/chromium/issues/detail?id=515627#c90.

Powered by Google App Engine
This is Rietveld 408576698