[DevTools] Added regex support in search for network tab

Added regex support in search for network tab

Users may now filter with regular expression (optional checkbox)
in the network tab

http://imgur.com/a0ZKF4f

BUG=576022
R=lushnikov

Committed: https://crrev.com/413558b12f7490a9a8a131da82f597b200b5a80d
Cr-Commit-Position: refs/heads/master@{#383266}

[allada, 2016-03-21 20:29:17]

PTL

[lushnikov, 2016-03-21 20:53:57]

Please, add a screenshot

[allada, 2016-03-21 21:01:20]

On 2016/03/21 20:53:57, lushnikov wrote:
> Please, add a screenshot

http://imgur.com/bp1dXGn

[lushnikov, 2016-03-21 21:49:27]

Please, add a "DevTools:" prefix to the issue title

And as discussed offline, we shouldn't show filtering suggestions in regex mode
to not confuse users.

https://codereview.chromium.org/1817193003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/1817193003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1945: *
@param {!RegExp} regex
fix annotation

[allada, 2016-03-21 21:56:02]

Description was changed from

==========
Added regex support in search for network tab

Users may now filter with regular expression (optional checkbox)
in the network tab

BUG=576022
R=lushnikov
==========

to

==========
Added regex support in search for network tab

Users may now filter with regular expression (optional checkbox)
in the network tab

BUG=576022
R=lushnikov
==========

[allada, 2016-03-21 22:50:45]

PTL

https://codereview.chromium.org/1817193003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/1817193003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1945: *
@param {!RegExp} regex
On 2016/03/21 21:49:27, lushnikov wrote:
> fix annotation

Done.

[allada, 2016-03-24 20:46:21]

Description was changed from

==========
Added regex support in search for network tab

Users may now filter with regular expression (optional checkbox)
in the network tab

BUG=576022
R=lushnikov
==========

to

==========
Added regex support in search for network tab

Users may now filter with regular expression (optional checkbox)
in the network tab

http://imgur.com/a0ZKF4f

BUG=576022
R=lushnikov
==========

[allada, 2016-03-24 20:58:19]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 20:58:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817193003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817193003/20001

[lushnikov, 2016-03-24 23:17:31]

lgtm, thanks!

https://codereview.chromium.org/1817193003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js (right):

https://codereview.chromium.org/1817193003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js:353: if
(this._suggestBox.visible())
you can safely call this._suggestBox.hide() without a check here.

[lushnikov, 2016-03-24 23:24:20]

nit: you usually don't want links to screenshot in the patch description; it's
better to put them as comments as a part of discussion

[commit-bot: I haz the power, 2016-03-25 00:04:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 00:04:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[allada, 2016-03-25 08:31:25]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2016-03-25 08:31:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817193003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817193003/20001

[commit-bot: I haz the power, 2016-03-25 09:33:07]

Description was changed from

==========
Added regex support in search for network tab

Users may now filter with regular expression (optional checkbox)
in the network tab

http://imgur.com/a0ZKF4f

BUG=576022
R=lushnikov
==========

to

==========
Added regex support in search for network tab

Users may now filter with regular expression (optional checkbox)
in the network tab

http://imgur.com/a0ZKF4f

BUG=576022
R=lushnikov
==========

[commit-bot: I haz the power, 2016-03-25 09:33:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-25 09:34:16]

Description was changed from

==========
Added regex support in search for network tab

Users may now filter with regular expression (optional checkbox)
in the network tab

http://imgur.com/a0ZKF4f

BUG=576022
R=lushnikov
==========

to

==========
Added regex support in search for network tab

Users may now filter with regular expression (optional checkbox)
in the network tab

http://imgur.com/a0ZKF4f

BUG=576022
R=lushnikov

Committed: https://crrev.com/413558b12f7490a9a8a131da82f597b200b5a80d
Cr-Commit-Position: refs/heads/master@{#383266}
==========

[commit-bot: I haz the power, 2016-03-25 09:34:18]

Patchset 2 (id:??) landed as
https://crrev.com/413558b12f7490a9a8a131da82f597b200b5a80d
Cr-Commit-Position: refs/heads/master@{#383266}