Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1817193003: [DevTools] Added regex support in search for network tab (Closed)

Created:
4 years, 9 months ago by allada
Modified:
4 years, 9 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added regex support in search for network tab Users may now filter with regular expression (optional checkbox) in the network tab http://imgur.com/a0ZKF4f BUG=576022 R=lushnikov Committed: https://crrev.com/413558b12f7490a9a8a131da82f597b200b5a80d Cr-Commit-Position: refs/heads/master@{#383266}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed cl issues #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -8 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 5 chunks +16 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js View 1 3 chunks +14 lines, -1 line 1 comment Download

Messages

Total messages: 19 (7 generated)
allada
PTL
4 years, 9 months ago (2016-03-21 20:29:17 UTC) #1
lushnikov
Please, add a screenshot
4 years, 9 months ago (2016-03-21 20:53:57 UTC) #2
allada
On 2016/03/21 20:53:57, lushnikov wrote: > Please, add a screenshot http://imgur.com/bp1dXGn
4 years, 9 months ago (2016-03-21 21:01:20 UTC) #3
lushnikov
Please, add a "DevTools:" prefix to the issue title And as discussed offline, we shouldn't ...
4 years, 9 months ago (2016-03-21 21:49:27 UTC) #4
allada
PTL https://codereview.chromium.org/1817193003/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/1817193003/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js#newcode1945 third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1945: * @param {!RegExp} regex On 2016/03/21 21:49:27, lushnikov ...
4 years, 9 months ago (2016-03-21 22:50:45 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817193003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817193003/20001
4 years, 9 months ago (2016-03-24 20:58:45 UTC) #9
lushnikov
lgtm, thanks! https://codereview.chromium.org/1817193003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js File third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js (right): https://codereview.chromium.org/1817193003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js#newcode353 third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js:353: if (this._suggestBox.visible()) you can safely call this._suggestBox.hide() ...
4 years, 9 months ago (2016-03-24 23:17:31 UTC) #10
lushnikov
nit: you usually don't want links to screenshot in the patch description; it's better to ...
4 years, 9 months ago (2016-03-24 23:24:20 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/201790)
4 years, 9 months ago (2016-03-25 00:04:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817193003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817193003/20001
4 years, 9 months ago (2016-03-25 08:31:33 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-25 09:33:08 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 09:34:18 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/413558b12f7490a9a8a131da82f597b200b5a80d
Cr-Commit-Position: refs/heads/master@{#383266}

Powered by Google App Engine
This is Rietveld 408576698