Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1817193002: [Android] Add minimal_symbols to remaining bots on chromium.{linux,android}. (Closed)

Created:
4 years, 9 months ago by jbudorick
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add minimal_symbols to remaining bots on chromium.{linux,android}. This includes: chromium.linux Android Clang Builder (dbg) Android GN (dbg) chromium.android Android GN Builder (dbg) BUG=596545 Committed: https://crrev.com/a5a755d1ec910cc8adf5ea4a05211e4f0af7e788 Cr-Commit-Position: refs/heads/master@{#382375}

Patch Set 1 #

Total comments: 2

Patch Set 2 : dpranke comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M tools/mb/mb_config.pyl View 1 4 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jbudorick
4 years, 9 months ago (2016-03-21 18:09:47 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/1817193002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1817193002/diff/1/tools/mb/mb_config.pyl#newcode272 tools/mb/mb_config.pyl:272: 'Android Clang Builder (dbg)': 'android_clang_asan_findbugs_gyp_debug_bot_minimal_symbols', nit: here and ...
4 years, 9 months ago (2016-03-21 18:58:37 UTC) #3
jbudorick
https://codereview.chromium.org/1817193002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1817193002/diff/1/tools/mb/mb_config.pyl#newcode272 tools/mb/mb_config.pyl:272: 'Android Clang Builder (dbg)': 'android_clang_asan_findbugs_gyp_debug_bot_minimal_symbols', On 2016/03/21 18:58:37, Dirk ...
4 years, 9 months ago (2016-03-21 19:03:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817193002/20001
4 years, 9 months ago (2016-03-21 19:03:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 20:38:41 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 20:40:20 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a5a755d1ec910cc8adf5ea4a05211e4f0af7e788
Cr-Commit-Position: refs/heads/master@{#382375}

Powered by Google App Engine
This is Rietveld 408576698