Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1817183002: Tweak test expectations for h/t/s/xssAuditor/script-tag-post-null-char.html (Closed)

Created:
4 years, 9 months ago by Łukasz Anforowicz
Modified:
4 years, 9 months ago
Reviewers:
alexmos
CC:
chromium-reviews, blink-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tweak test expectations for h/t/s/xssAuditor/script-tag-post-null-char.html Since the beginning, site-per-process test expectations covered http/tests/security/xssAuditor/script-tag-post-null-char.html expecting a timeout. Recently this test started to fail with "Unexpected text-only failures" on the linux_site_isolation FYI bot (at a rate of 4 failures per ~17 builds - from build 8460 to 8477). So far we've been unable to repro this failure locally. BUG=477150 Committed: https://crrev.com/1b127b3afd5789fd348aba55bbc6a0510791824f Cr-Commit-Position: refs/heads/master@{#382372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Łukasz Anforowicz
Alex, could you please take a look?
4 years, 9 months ago (2016-03-21 19:05:40 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817183002/1
4 years, 9 months ago (2016-03-21 19:06:04 UTC) #5
alexmos
LGTM
4 years, 9 months ago (2016-03-21 19:43:58 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-21 20:15:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817183002/1
4 years, 9 months ago (2016-03-21 20:24:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 20:30:39 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 20:32:16 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b127b3afd5789fd348aba55bbc6a0510791824f
Cr-Commit-Position: refs/heads/master@{#382372}

Powered by Google App Engine
This is Rietveld 408576698