Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1817163003: Revert of Parser: Make skipping HTML comments optional. (Closed)

Created:
4 years, 9 months ago by vogelheim
Modified:
4 years, 9 months ago
CC:
ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Parser: Make skipping HTML comments optional. (patchset #6 id:140001 of https://codereview.chromium.org/1801203002/ ) Reason for revert: Violates ES6 spec (crbug.com/4850), and implementation was over-eager. Will revert for now. Original issue's description: > Parser: Make skipping HTML comments optional. > > API change: This adds a new flag skip_html_comments to v8::ScriptOriginOptions. This flag controls whether V8 will attempt to honour HTML-style comments in JS sources. > > (That is: Gracefully ignore <!-- ... ---> in JS sources, which was a popular technique in the early days of JavaScript, to prevent non-JS-enabled browsers from displaying script sources to uses.) > > The flag defaults to 'true' when using v8::ScriptOrigin constructor, which preserves the existing behaviour. Embedders which are happy with the existing behaviour will thus not need any changes. > > BUG=chromium:573887 > LOG=Y > > Committed: https://crrev.com/91d344288aa51ed03eaaa1cb3e368ac1e82f0173 > Cr-Commit-Position: refs/heads/master@{#34904} TBR=jochen@chromium.org,rossberg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:573887, v8:4850 LOG=Y Committed: https://crrev.com/09ac4f295c111811fffc91dcc9fd468c2c3207be Cr-Commit-Position: refs/heads/master@{#34958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -115 lines) Patch
M include/v8.h View 4 chunks +15 lines, -21 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/parsing/scanner.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/parsing/scanner.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M test/cctest/test-parsing.cc View 15 chunks +14 lines, -40 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
vogelheim
Created Revert of Parser: Make skipping HTML comments optional.
4 years, 9 months ago (2016-03-21 16:59:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817163003/1
4 years, 9 months ago (2016-03-21 16:59:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817163003/1
4 years, 9 months ago (2016-03-21 17:02:24 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12689)
4 years, 9 months ago (2016-03-21 17:04:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817163003/1
4 years, 9 months ago (2016-03-21 17:15:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 17:48:34 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 17:50:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09ac4f295c111811fffc91dcc9fd468c2c3207be
Cr-Commit-Position: refs/heads/master@{#34958}

Powered by Google App Engine
This is Rietveld 408576698