Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1817153002:
Remove transitional explicit operator bool. (Closed)
DescriptionRemove transitional explicit operator bool.
These should no longer be necessary. Android's STL should now
be sane.
TBR=reed
This just removes code.
Committed: https://skia.googlesource.com/skia/+/04cdc4b61879849df63e883e68eecafe6510f423
Patch Set 1 #
Messages
Total messages: 25 (14 generated)
Description was changed from ========== These should no longer be necessary? BUG=skia: ========== to ========== These should no longer be necessary? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
mtklein@chromium.org changed reviewers: + bungeman@google.com
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817153002/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-03-21 22:10 UTC
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
Description was changed from ========== These should no longer be necessary? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== These should no longer be necessary. Android's STL should now be sane. ==========
Description was changed from ========== These should no longer be necessary. Android's STL should now be sane. ========== to ========== Remove transitional explicit operator bool. These should no longer be necessary. Android's STL should now be sane. ==========
lgtm
The CQ bit was checked by mtklein@google.com
Description was changed from ========== Remove transitional explicit operator bool. These should no longer be necessary. Android's STL should now be sane. ========== to ========== Remove transitional explicit operator bool. These should no longer be necessary. Android's STL should now be sane. TBR=reed@google.com ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817153002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817153002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
Description was changed from ========== Remove transitional explicit operator bool. These should no longer be necessary. Android's STL should now be sane. ========== to ========== Remove transitional explicit operator bool. These should no longer be necessary. Android's STL should now be sane. TBR=reed This just removes code. ==========
The CQ bit was checked by bungeman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817153002/1
Message was sent while issue was closed.
Description was changed from ========== Remove transitional explicit operator bool. These should no longer be necessary. Android's STL should now be sane. TBR=reed This just removes code. ========== to ========== Remove transitional explicit operator bool. These should no longer be necessary. Android's STL should now be sane. TBR=reed This just removes code. Committed: https://skia.googlesource.com/skia/+/04cdc4b61879849df63e883e68eecafe6510f423 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/04cdc4b61879849df63e883e68eecafe6510f423 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
