Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1817143002: Use LocalStyleChange for text direction changes. (Closed)

Created:
4 years, 9 months ago by rune
Modified:
4 years, 9 months ago
Reviewers:
Timothy Loh, kojii
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use LocalStyleChange for text direction changes. Changing the dir attribute or inserting text content into the document may affect the CSS direction property through presentation style. The code traversed and marked the parent elements affected by such changes but use SubtreeStyleChange which recalculate more style than necessary. Instead use LocalStyleChange as that will also cause inheritance to happen appropriately. R=kojii@chromium.org BUG=596509 Committed: https://crrev.com/19ae473e9890bba140facef0127941554a2d5718 Cr-Commit-Position: refs/heads/master@{#382442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/dir-auto-insert-text-invalidation.html View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/dir-auto-insert-text-invalidation-expected.txt View 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
rune
ptal
4 years, 9 months ago (2016-03-21 16:09:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817143002/1
4 years, 9 months ago (2016-03-21 16:09:48 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-21 17:50:29 UTC) #5
Timothy Loh
On 2016/03/21 17:50:29, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 9 months ago (2016-03-21 23:37:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817143002/1
4 years, 9 months ago (2016-03-21 23:48:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 23:53:57 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/19ae473e9890bba140facef0127941554a2d5718 Cr-Commit-Position: refs/heads/master@{#382442}
4 years, 9 months ago (2016-03-21 23:55:15 UTC) #11
kojii
4 years, 9 months ago (2016-03-22 02:13:57 UTC) #12
Message was sent while issue was closed.
lgtm, thanks for doing this.

Powered by Google App Engine
This is Rietveld 408576698