Issue 181713003: Have Document::accessSVGExtensions() return a reference

Issue 181713003: Have Document::accessSVGExtensions() return a reference (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
adamk, eseidel

CC:
blink-reviews, shans, eae+blinkwatch, fs, adamk+blink_chromium.org, Steve Block, dino_apple.com, rwlbuis, krit, alancutter (OOO until 2018), bemjb+rendering_chromium.org, dsinclair, Timothy Loh, dstockwell, dglazkov+blink, jchaffraix+rendering, pdr., Eric Willigers, rjwright, zoltan1, sof, gyuyoung.kim_webkit.org, darktears, leviw+renderwatch, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Inactive, Stephen Chennney

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have Document::accessSVGExtensions() return a reference Have Document::accessSVGExtensions() return a reference instead of a pointer as it can never return null. This makes the calling code look safer. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167959

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -87 lines)			Patch
M	Source/core/dom/Document.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Document.cpp	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderView.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/svg/ReferenceFilterBuilder.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/svg/RenderSVGResource.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/svg/RenderSVGResourceContainer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/svg/RenderSVGResourceContainer.cpp	View	4 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/core/rendering/svg/SVGResources.cpp	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	Source/core/rendering/svg/SVGResourcesCache.cpp	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	Source/core/svg/SVGAnimateElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGElement.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGElement.cpp	View	7 chunks	+17 lines, -17 lines	0 comments	Download
M	Source/core/svg/SVGFEConvolveMatrixElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGFEImageElement.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGFitToViewBox.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGFontFaceElement.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGMPathElement.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/svg/SVGPathElement.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGSVGElement.cpp	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/svg/SVGTextPathElement.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/svg/SVGUseElement.cpp	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/svg/animation/SVGSMILElement.cpp	View	3 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/181713003/1

6 years, 10 months ago (2014-02-26 19:10:26 UTC) #3

Message was sent while issue was closed.

Change committed as 167959

Expand Messages | Collapse Messages