Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: remoting/base/running_samples_unittest.cc

Issue 1817093005: Revert of Show max latency on client's status bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/base/running_samples.cc ('k') | remoting/client/jni/chromoting_jni_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/base/running_samples_unittest.cc
diff --git a/remoting/base/running_samples_unittest.cc b/remoting/base/running_samples_unittest.cc
deleted file mode 100644
index 2c2c7f55557337c5a2112b461af1e4758c4baed6..0000000000000000000000000000000000000000
--- a/remoting/base/running_samples_unittest.cc
+++ /dev/null
@@ -1,92 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include <stddef.h>
-#include <stdint.h>
-
-#include "base/macros.h"
-#include "remoting/base/running_samples.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace remoting {
-
-typedef void (*TestFunction)(size_t i, RunningSamples& samples);
-
-static const int64_t kTestValues[] = { 10, 20, 30, 10, 25, 16, 15 };
-
-// Test framework that verifies average() and max() at beginning, iterates
-// through all elements and meanwhile calls your own test function
-static void TestFramework(int windowSize, TestFunction testFn) {
- RunningSamples samples(windowSize);
- EXPECT_EQ(0, samples.Average());
- EXPECT_EQ(0, samples.Max());
-
- for (size_t i = 0; i < arraysize(kTestValues); ++i) {
- samples.Record(kTestValues[i]);
- testFn(i, samples);
- }
-}
-
-// Average across a single element, i.e. just return the most recent.
-TEST(RunningSamplesTest, AverageOneElementWindow) {
- TestFramework(1, [](size_t i, RunningSamples& samples) {
- EXPECT_EQ(static_cast<double>(kTestValues[i]), samples.Average());
- });
-}
-
-// Average the two most recent elements.
-TEST(RunningSamplesTest, AverageTwoElementWindow) {
- TestFramework(2, [](size_t i, RunningSamples& samples) {
- double expected = kTestValues[i];
- if (i > 0)
- expected = (expected + kTestValues[i-1]) / 2;
-
- EXPECT_EQ(expected, samples.Average());
- });
-}
-
-// Average across all the elements if the window size exceeds the element count.
-TEST(RunningSamplesTest, AverageLongWindow) {
- TestFramework(arraysize(kTestValues) + 1,
- [](size_t i, RunningSamples& samples) {
- double expected = 0.0;
- for (size_t j = 0; j <= i; ++j)
- expected += kTestValues[j];
- expected /= i + 1;
-
- EXPECT_EQ(expected, samples.Average());
- });
-}
-
-// Max of a single element, i.e. just return the most recent.
-TEST(RunningSamplesTest, MaxOneElementWindow) {
- TestFramework(1, [](size_t i, RunningSamples& samples) {
- EXPECT_EQ(static_cast<double>(kTestValues[i]), samples.Max());
- });
-}
-
-// Max of the two most recent elements.
-TEST(RunningSamplesTest, MaxTwoElementWindow) {
- TestFramework(2, [](size_t i, RunningSamples& samples) {
- double expected = kTestValues[i];
- if (i > 0)
- expected = expected > kTestValues[i-1] ? expected : kTestValues[i-1];
-
- EXPECT_EQ(expected, samples.Max());
- });
-}
-
-// Max of all the elements if the window size exceeds the element count.
-TEST(RunningSamplesTest, MaxLongWindow) {
- TestFramework(arraysize(kTestValues) + 1,
- [](size_t i, RunningSamples& samples) {
- int64_t expected = -1;
- for (size_t j = 0; j <= i; ++j)
- expected = expected > kTestValues[j] ? expected : kTestValues[j];
-
- EXPECT_EQ(expected, samples.Max());
- });
-}
-
-} // namespace remoting
« no previous file with comments | « remoting/base/running_samples.cc ('k') | remoting/client/jni/chromoting_jni_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698