Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1817093005: Revert of Show max latency on client's status bar (Closed)

Created:
4 years, 9 months ago by newt (away)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Show max latency on client's status bar (patchset #8 id:140001 of https://codereview.chromium.org/1811833002/ ) Reason for revert: Caused compile failure on 64-bit Android bots. See crbug.com/597155 Original issue's description: > Show max latency on client's status bar > > Will later also consider storing max latency data in server > > BUG=560950 > > Committed: https://crrev.com/e37a467453f3814a9ecb0eb6769bd7c58b61cbae > Cr-Commit-Position: refs/heads/master@{#382663} TBR=sergeyu@chromium.org,kelvinp@chromium.org,dbeam@chromium.org,yuweih@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=560950 Committed: https://crrev.com/53300ca20e00981cc46a30395a635246d154ddd3 Cr-Commit-Position: refs/heads/master@{#382777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -306 lines) Patch
M remoting/base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A remoting/base/running_average.h View 1 chunk +51 lines, -0 lines 0 comments Download
A remoting/base/running_average.cc View 1 chunk +39 lines, -0 lines 0 comments Download
A remoting/base/running_average_unittest.cc View 1 chunk +60 lines, -0 lines 0 comments Download
D remoting/base/running_samples.h View 1 chunk +0 lines, -57 lines 0 comments Download
D remoting/base/running_samples.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D remoting/base/running_samples_unittest.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M remoting/client/jni/chromoting_jni_instance.cc View 1 chunk +5 lines, -13 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M remoting/client/server_log_entry_client.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/protocol/capture_scheduler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/performance_tracker.h View 3 chunks +11 lines, -11 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/remoting_test.gypi View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/base/js/chromoting_event.js View 1 chunk +0 lines, -10 lines 0 comments Download
M remoting/webapp/base/js/connection_stats.js View 1 chunk +9 lines, -22 lines 0 comments Download
M remoting/webapp/base/js/session_logger.js View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/webapp/base/js/stats_accumulator.js View 2 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
newt (away)
Created Revert of Show max latency on client's status bar
4 years, 9 months ago (2016-03-23 02:21:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817093005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817093005/1
4 years, 9 months ago (2016-03-23 02:22:04 UTC) #2
commit-bot: I haz the power
Failed to apply patch for remoting/webapp/base/js/connection_stats.js: While running git apply --index -3 -p1; error: patch ...
4 years, 9 months ago (2016-03-23 02:22:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817093005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817093005/1
4 years, 9 months ago (2016-03-23 02:56:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 02:56:45 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 02:58:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53300ca20e00981cc46a30395a635246d154ddd3
Cr-Commit-Position: refs/heads/master@{#382777}

Powered by Google App Engine
This is Rietveld 408576698