Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1817083002: Revert of [libphonenumber] Run tests on swarming (Closed)

Created:
4 years, 9 months ago by phoglund_chromium
Modified:
4 years, 9 months ago
Reviewers:
Mathieu, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [libphonenumber] Run tests on swarming (patchset #5 id:80001 of https://codereview.chromium.org/1759723002/ ) Reason for revert: PhoneNumberMatcherTest.MatchesWithStrictGroupingLeniency fails on Win 7: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/47005 Original issue's description: > [libphonenumber] Run tests on swarming > > Also adding some files and their tests. > > BUG=585151 > > Committed: https://crrev.com/85d385a2ec9f6d365fee5a14fd2a5ea564ffb1a7 > Cr-Commit-Position: refs/heads/master@{#382114} TBR=thakis@chromium.org,mathp@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=585151 Committed: https://crrev.com/2357e829b7b0bd3e25de9948725c70520c950903 Cr-Commit-Position: refs/heads/master@{#382299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -94 lines) Patch
M testing/buildbot/chromium.linux.json View 2 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 2 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/chromium.win.json View 2 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/libphonenumber/BUILD.gn View 3 chunks +1 line, -11 lines 0 comments Download
M third_party/libphonenumber/libphonenumber.gyp View 2 chunks +1 line, -23 lines 0 comments Download
D third_party/libphonenumber/libphonenumber_unittests.isolate View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
phoglund_chromium
Created Revert of [libphonenumber] Run tests on swarming
4 years, 9 months ago (2016-03-21 14:33:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817083002/1
4 years, 9 months ago (2016-03-21 14:33:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817083002/1
4 years, 9 months ago (2016-03-21 15:01:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817083002/1
4 years, 9 months ago (2016-03-21 15:31:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 15:58:14 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 15:59:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2357e829b7b0bd3e25de9948725c70520c950903
Cr-Commit-Position: refs/heads/master@{#382299}

Powered by Google App Engine
This is Rietveld 408576698