Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: tools/eval_gc_time.sh

Issue 1817063002: [tools] Default to stdin for processing in eval_gc_time.sh (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/eval_gc_time.sh
diff --git a/tools/eval_gc_time.sh b/tools/eval_gc_time.sh
index 1459eb0c19d4383c4d220550377df0c9814afe3b..cef38df3c328b6c12f8192543c6b9f0ca6788d7c 100755
--- a/tools/eval_gc_time.sh
+++ b/tools/eval_gc_time.sh
@@ -7,11 +7,16 @@
# Convenience Script used to rank GC NVP output.
print_usage_and_die() {
- echo "Usage: $0 new-gen-rank|old-gen-rank max|avg logfile"
+ echo "Usage: $0 RANK SORT [LOGFILE]"
+ echo ""
+ echo "Arguments:"
+ echo " RANK: old-gen-rank | new-gen-rank"
+ echo " SORT: max | avg"
+ echo " LOGFILE: the file to process. will default to /dev/stdin"
exit 1
}
-if [ $# -ne 3 ]; then
+if [[ $# -lt 2 || $# -gt 3 ]]; then
print_usage_and_die
fi
@@ -31,7 +36,11 @@ case $2 in
print_usage_and_die
esac
-LOGFILE=$3
+if [ $# -eq 3 ]; then
+ LOGFILE=$3
+else
+ LOGFILE=/dev/stdin
+fi
GENERAL_INTERESTING_KEYS="\
pause \
@@ -95,7 +104,7 @@ case $OP in
${INTERESTING_NEW_GEN_KEYS}
;;
old-gen-rank)
- cat $LOGFILE | grep "gc=ms" | grep "reduce_memory=0" | grep -v "steps=0" \
+ cat $LOGFILE | grep "gc=ms" \
| $BASE_DIR/eval_gc_nvp.py \
--no-histogram \
--rank $RANK_MODE \
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698