Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3804)

Unified Diff: chrome/browser/resources/options/password_manager_list.js

Issue 1817053002: [Password Manager] Changes implementation of left elided origin on chrome://settings/passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cache computed style. Skip eliding for Android credentials. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/password_manager_list.js
diff --git a/chrome/browser/resources/options/password_manager_list.js b/chrome/browser/resources/options/password_manager_list.js
index 58bd5efce0d831ca12c006fbb9a0b77277e8f14e..f54d777f31572dfbfe3fc1118b1c42ee47cb3dd5 100644
--- a/chrome/browser/resources/options/password_manager_list.js
+++ b/chrome/browser/resources/options/password_manager_list.js
@@ -58,9 +58,6 @@ cr.define('options.passwordManager', function() {
title = title.substring(ind + 3);
}
}
- // Since the direction is switched to RTL, punctuation symbols appear on the
- // left side, that is wrong. So, just remove trailing punctuation symbols.
- title = title.replace(/[^A-Za-z0-9]+$/, '');
return title;
}
@@ -78,13 +75,11 @@ cr.define('options.passwordManager', function() {
urlLink = item.ownerDocument.createElement('a');
urlLink.href = item.url;
urlLink.setAttribute('target', '_blank');
- urlLink.textContent = item.shownUrl.split('').reverse().join('');
-
- urlDiv.classList.add('left-elided-url');
+ urlLink.dir = 'ltr';
} else {
urlLink = item.ownerDocument.createElement('span');
- urlLink.textContent = item.shownUrl;
}
+ urlLink.textContent = item.shownUrl;
urlLink.addEventListener('focus', function() {
item.handleFocus();
}.bind(item));
@@ -108,6 +103,7 @@ cr.define('options.passwordManager', function() {
this.urlLink = createUrlLink(this, urlDiv);
urlDiv.appendChild(this.urlLink);
+ this.urlDiv = urlDiv;
this.contentElement.appendChild(urlDiv);
// The stored username.
@@ -373,6 +369,7 @@ cr.define('options.passwordManager', function() {
this.urlLink = createUrlLink(this, urlDiv);
urlDiv.appendChild(this.urlLink);
+ this.urlDiv = urlDiv;
this.contentElement.appendChild(urlDiv);
},

Powered by Google App Engine
This is Rietveld 408576698