[Interpreter] Add dispatch counters for each bytecode.

src/d8.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 // Defined when linking against shared lib on Windows.
 #if defined(USING_V8_SHARED) && !defined(V8_SHARED)
 #define V8_SHARED
 #endif
 
 #include <errno.h>
+#include <inttypes.h>
 #include <stdlib.h>
 #include <string.h>
 #include <sys/stat.h>
 
 #ifdef V8_SHARED
 #include <assert.h>
 #endif  // V8_SHARED
 
 #ifndef V8_SHARED
 #include <algorithm>
@@ skipping 12 matching lines @@
 #include "src/ostreams.h"
 
 #include "include/libplatform/libplatform.h"
 #ifndef V8_SHARED
 #include "src/api.h"
 #include "src/base/cpu.h"
 #include "src/base/logging.h"
 #include "src/base/platform/platform.h"
 #include "src/base/sys-info.h"
 #include "src/basic-block-profiler.h"
+#include "src/interpreter/interpreter.h"
 #include "src/snapshot/natives.h"
 #include "src/utils.h"
 #include "src/v8.h"
 #endif  // !V8_SHARED
 
 #if !defined(_WIN32) && !defined(_WIN64)
 #include <unistd.h>  // NOLINT
 #else
 #include <windows.h>  // NOLINT
 #if defined(_MSC_VER)
@@ skipping 1243 matching lines @@
   Counter* counter;
   const char* key;
 };
 
 
 inline bool operator<(const CounterAndKey& lhs, const CounterAndKey& rhs) {
   return strcmp(lhs.key, rhs.key) < 0;
 }
 #endif  // !V8_SHARED
 
+void Shell::DumpHandlersDispatchCounters(FILE* stream, Isolate* isolate) {

[rmcilroy, 2016/04/05 10:00:45]

WriteInterpreterDispatchCounters

[Stefano Sanfilippo, 2016/04/05 14:01:45]

Done.

+  uint32_t* handler_dispatch_counters = reinterpret_cast<i::Isolate*>(isolate)
+                                            ->interpreter()
+                                            ->handlers_dispatch_counters();
+
+  fputc('{', stream);

[rmcilroy, 2016/04/05 10:00:45]

Can we just use an ostream instead of the c file output?

[Stefano Sanfilippo, 2016/04/05 14:01:45]

Done.

+  for (int i = 0; i < i::interpreter::Interpreter::kCountersTableRowSize; ++i) {
+    if (i > 0) fputs(", ", stream);
+    i::interpreter::Bytecode bytecode = i::interpreter::Bytecodes::FromByte(i);
+    fprintf(stream, "\"%s\": %" PRIu32,
+            i::interpreter::Bytecodes::ToString(bytecode),
+            handler_dispatch_counters[i]);
+  }
+  fputc('}', stream);
+}
 
 void Shell::OnExit(v8::Isolate* isolate) {
 #ifndef V8_SHARED
   if (i::FLAG_dump_counters) {
     int number_of_counters = 0;
     for (CounterMap::Iterator i(counter_map_); i.More(); i.Next()) {
       number_of_counters++;
     }
     CounterAndKey* counters = new CounterAndKey[number_of_counters];
     int j = 0;
@@ skipping 15 matching lines @@
         printf("| c:%-60s | %11i |\n", key, counter->count());
         printf("| t:%-60s | %11i |\n", key, counter->sample_total());
       } else {
         printf("| %-62s | %11i |\n", key, counter->count());
       }
     }
     printf("+----------------------------------------------------------------+"
            "-------------+\n");
     delete [] counters;
   }
+
+  if (i::FLAG_ignition_count_handler_dispatches) {
+    FILE* ignition_counters_stream =
+        fopen(i::FLAG_ignition_handler_to_handler_output_file, "w");

[rmcilroy, 2016/04/05 10:00:45]

nit - just do the open / close in WriteInterpreterDispatchCounters

[Stefano Sanfilippo, 2016/04/05 14:01:45]

I'd rather open the stream externally and pass it to the function, since in the
followup we will be serializing both tables to the same file.

+    CHECK_NOT_NULL(ignition_counters_stream);
+    DumpHandlersDispatchCounters(ignition_counters_stream, isolate);
+    fclose(ignition_counters_stream);
+  }
+
   delete counters_file_;
   delete counter_map_;
 #endif  // !V8_SHARED
 }
 
 
 
 static FILE* FOpen(const char* path, const char* mode) {
 #if defined(_MSC_VER) && (defined(_WIN32) || defined(_WIN64))
   FILE* result;
@@ skipping 1181 matching lines @@
 }
 
 }  // namespace v8
 
 
 #ifndef GOOGLE3
 int main(int argc, char* argv[]) {
   return v8::Shell::Main(argc, argv);
 }
 #endif