Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 181703005: Cleanup: Rename http_message_test_utils.{h,cc,_test.cc} to (Closed)

Created:
6 years, 10 months ago by ramant (doing other things)
Modified:
6 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Rename http_message_test_utils.{h,cc,_test.cc} to http_message.{h,cc,_test.cc} This is how it should be named (defines/tests class HTTPMessage), and it's confusingly similar to the unrelated http_message_utils.h n/a (test only) Merge internal change: 61955207 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -315 lines) Patch
M net/net.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/tools/quic/test_tools/http_message.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/tools/quic/test_tools/http_message.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/tools/quic/test_tools/http_message_test_utils.h View 1 chunk +0 lines, -133 lines 0 comments Download
D net/tools/quic/test_tools/http_message_test_utils.cc View 1 chunk +0 lines, -174 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 10 months ago (2014-02-26 19:32:35 UTC) #1
Ryan Hamilton
6 years, 9 months ago (2014-02-26 22:18:52 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698