Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: tests/language/named_parameters_with_conversions_test.dart

Issue 18170003: Fix bug in the inliner when dealing with named optional parameters. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/named_parameters_with_conversions_test.dart
===================================================================
--- tests/language/named_parameters_with_conversions_test.dart (revision 24943)
+++ tests/language/named_parameters_with_conversions_test.dart (working copy)
@@ -4,6 +4,7 @@
//
// Test named arguments work as expected regardless of whether the function or
// method is called via function call syntax or method call syntax.
+// VMOptions=--optimization-counter-threshold=10
import "package:expect/expect.dart";
@@ -99,7 +100,8 @@
checkException(() => a.foo()); // Too few arguments.
checkException(() => a.foo('abc', 1, 2, 3)); // Too many arguments.
- checkException(() => a.foo2('c', c: 1)); // Bad name.
+ checkException(() => a.foo2('c', c: 1)); // Bad name.
+ checkException(() => a.foo2('c', a:111, c: 1)); // Bad name.
Expect.equals(7, a.calls);
}
@@ -119,7 +121,8 @@
checkException(() => f()); // Too few arguments.
checkException(() => f('abc', 1, 2, 3)); // Too many arguments.
- checkException(() => f2('c', c: 1)); // Bad name.
+ checkException(() => f2('c', c: 1)); // Bad name.
+ checkException(() => f2('c', a: 111, c: 1)); // Bad name.
Expect.equals(7, a.calls);
}
@@ -137,5 +140,7 @@
}
main() {
- NamedParametersWithConversionsTest.testMain();
+ for (var i = 0; i < 20; i++) {
+ NamedParametersWithConversionsTest.testMain();
+ }
}
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698