Add a setting to allow window object reuse across a top-level initial navigation.

Add a setting to allow window object reuse across a top-level initial navigation.

r378508 fixed Blink's plumbing to remove the concept failed security context
initialization. This breaks Android WebView though: previously a main frame with
no opener would "fail to initialize", and the window object would be reused in
the initial navigation. Now, a main frame with no opener is just treated as
unique origin: this means it always fails the shouldReuseDefaultView() check and
the window object is not reused across the initial navigation. Unfortunately, a
number of Android apps depend on injecting script into the main frame and having
it persist on the first navigation.

The new setting is essentially an escape hatch for Android WebView: a main frame
that is the only browsing context in its unit of related browsing contexts can
only have script injected by the embedder. In this case, it's OK to allow reuse
(aka universal access) on the initial navigation, since no web content could
have injected script.

BUG=593984
Committed: https://crrev.com/73f32aae5298f6a3779385fc4b6bdb08f6e070a5
Cr-Commit-Position: refs/heads/master@{#385263}

[dcheng, 2016-04-02 00:47:23]

Description was changed from

==========
Android WebView =(

BUG=
==========

to

==========
Add a setting to allow window object reuse across a top-level initial
navigation.

BUG=593984
==========

[dcheng, 2016-04-02 00:47:23]

dcheng@chromium.org changed reviewers:
+ japhet@chromium.org

[dcheng, 2016-04-02 00:52:36]

Description was changed from

==========
Add a setting to allow window object reuse across a top-level initial
navigation.

BUG=593984
==========

to

==========
Add a setting to allow window object reuse across a top-level initial
navigation.

r378508 fixed Blink's plumbing to remove the concept failed security context
initialization. This breaks Android WebView though: previously a main frame with
no opener would "fail to initialize", and the window object would be reused in
the initial navigation. Now, a main frame with no opener is just treated as
unique origin: this means it always fails the shouldReuseDefaultView() check and
the window object is not reused across the initial navigation. Unfortunately, a
number of Android apps depend on injecting script into the main frame and having
it persist on the first navigation.

The new setting is essentially an escape hatch for Android WebView: a main frame
that is the only browsing context in its unit of related browsing contexts can
only have script injected by the embedder. In this case, it's OK to allow reuse
(aka universal access) on the initial navigation, since no web content could
have injected script.

BUG=593984
==========

[dcheng, 2016-04-02 00:52:47]

dcheng@chromium.org changed reviewers:
+ jochen@chromium.org

[dcheng, 2016-04-02 00:52:48]

Meh.

[jochen (gone - plz use gerrit), 2016-04-04 12:08:59]

lgtm

[Nate Chapin, 2016-04-05 18:35:54]

On 2016/04/04 12:08:59, jochen wrote:
> lgtm

lgtm.

lbtm, but lgtm.

[dcheng, 2016-04-05 18:38:58]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-04-05 18:39:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1816983002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1816983002/100001

[commit-bot: I haz the power, 2016-04-05 19:47:47]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-05 19:49:45]

Description was changed from

==========
Add a setting to allow window object reuse across a top-level initial
navigation.

r378508 fixed Blink's plumbing to remove the concept failed security context
initialization. This breaks Android WebView though: previously a main frame with
no opener would "fail to initialize", and the window object would be reused in
the initial navigation. Now, a main frame with no opener is just treated as
unique origin: this means it always fails the shouldReuseDefaultView() check and
the window object is not reused across the initial navigation. Unfortunately, a
number of Android apps depend on injecting script into the main frame and having
it persist on the first navigation.

The new setting is essentially an escape hatch for Android WebView: a main frame
that is the only browsing context in its unit of related browsing contexts can
only have script injected by the embedder. In this case, it's OK to allow reuse
(aka universal access) on the initial navigation, since no web content could
have injected script.

BUG=593984
==========

to

==========
Add a setting to allow window object reuse across a top-level initial
navigation.

r378508 fixed Blink's plumbing to remove the concept failed security context
initialization. This breaks Android WebView though: previously a main frame with
no opener would "fail to initialize", and the window object would be reused in
the initial navigation. Now, a main frame with no opener is just treated as
unique origin: this means it always fails the shouldReuseDefaultView() check and
the window object is not reused across the initial navigation. Unfortunately, a
number of Android apps depend on injecting script into the main frame and having
it persist on the first navigation.

The new setting is essentially an escape hatch for Android WebView: a main frame
that is the only browsing context in its unit of related browsing contexts can
only have script injected by the embedder. In this case, it's OK to allow reuse
(aka universal access) on the initial navigation, since no web content could
have injected script.

BUG=593984

Committed: https://crrev.com/73f32aae5298f6a3779385fc4b6bdb08f6e070a5
Cr-Commit-Position: refs/heads/master@{#385263}
==========

[commit-bot: I haz the power, 2016-04-05 19:49:46]

Patchset 6 (id:??) landed as
https://crrev.com/73f32aae5298f6a3779385fc4b6bdb08f6e070a5
Cr-Commit-Position: refs/heads/master@{#385263}