third_party/WebKit/Source/devtools/front_end/ui/Popover.js - Issue 1816933002: Devtools: Cut color picker off at bottom instead of the top

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Popover.js

Issue 1816933002: Devtools: Cut color picker off at bottom instead of the top (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/elements/spectrum.css ('K') | « third_party/WebKit/Source/devtools/front_end/elements/spectrum.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/ui/Popover.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js

index cccb6642a28b6339b83807cb020678f627e0853b..576fcb908a892f9c31013d6a9b77602d3eb4a0dd 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js

@@ -240,7 +240,7 @@ WebInspector.Popover.prototype = {

}

this.element.className = WebInspector.Popover._classNamePrefix + " " + verticalAlignment + "-" + horizontalAlignment + "-arrow";

- this.element.positionAt(newElementPosition.x, newElementPosition.y - borderWidth, container);

+ this.element.positionAt(newElementPosition.x, Math.max(0, newElementPosition.y - borderWidth), container);

this.element.style.width = newElementPosition.width + borderWidth * 2 + "px";

this.element.style.height = newElementPosition.height + borderWidth * 2 + "px";