Issue 181693003: Have Document::markers() return a reference

Issue 181693003: Have Document::markers() return a reference (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
adamk

CC:
blink-reviews, zoltan1, dsinclair, sof, eae+blinkwatch, groby+blinkspell_chromium.org, leviw+renderwatch, dglazkov+blink, adamk+blink_chromium.org, jchaffraix+rendering, Inactive, bemjb+rendering_chromium.org, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have Document::markers() return a reference Have Document::markers() return a reference instead of a pointer as it can never return null. This makes the calling code look safer. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167957

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -63 lines)			Patch
M	Source/core/dom/Document.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/DocumentMarkerControllerTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Node.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/CompositeEditCommand.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/editing/Editor.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/SpellCheckRequester.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/SpellChecker.cpp	View	10 chunks	+14 lines, -14 lines	0 comments	Download
M	Source/core/editing/SplitTextNodeCommand.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/TextCheckingHelper.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/frame/FrameView.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/page/EventHandler.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/Page.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/HitTestResult.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/InlineTextBox.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/testing/Internals.cpp	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/web/ContextMenuClientImpl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/SpellCheckerClientImpl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebFrameImpl.cpp	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/tests/WebFrameTest.cpp	View	4 chunks	+16 lines, -16 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/181693003/1

6 years, 10 months ago (2014-02-26 17:27:18 UTC) #3

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 10 months ago (2014-02-26 23:26:50 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=29180

6 years, 10 months ago (2014-02-26 23:26:51 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/181693003/1

6 years, 10 months ago (2014-02-27 00:08:45 UTC) #7

Message was sent while issue was closed.

Change committed as 167957

Expand Messages | Collapse Messages