Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1816923002: Move constant implementation out of generated (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9347 lines, -9295 lines) Patch
A pkg/analyzer/lib/context/declared_variables.dart View 1 chunk +88 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/dart/constant/evaluation.dart View 1 chunk +2003 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/dart/constant/utilities.dart View 1 chunk +312 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/dart/constant/value.dart View 1 chunk +2818 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 3 chunks +8 lines, -5155 lines 0 comments Download
A pkg/analyzer/test/context/declared_variables_test.dart View 1 chunk +116 lines, -0 lines 0 comments Download
A + pkg/analyzer/test/context/test_all.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/constant_test.dart View 2 chunks +0 lines, -4132 lines 0 comments Download
A pkg/analyzer/test/src/dart/constant/evaluation_test.dart View 1 chunk +1603 lines, -0 lines 0 comments Download
A + pkg/analyzer/test/src/dart/constant/test_all.dart View 1 chunk +6 lines, -2 lines 0 comments Download
A pkg/analyzer/test/src/dart/constant/utilities_test.dart View 1 chunk +354 lines, -0 lines 0 comments Download
A pkg/analyzer/test/src/dart/constant/value_test.dart View 1 chunk +2029 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/test_all.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/test/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 9 months ago (2016-03-20 21:35:10 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-20 21:48:51 UTC) #3
Brian Wilkerson
4 years, 9 months ago (2016-03-20 22:07:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a310a1684882e17144a3cca0b8695872470bd2f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698