Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: Source/bindings/dart/DartDebugServer.h

Issue 18169002: Improve Dart Debugger performance and robustness by creating Dart wrappers using the standard SetNa… (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: Code review fixes Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/dart/DartDebugHooks.js ('k') | Source/bindings/dart/DartDebugServer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 static DartDebugServer& shared(); 47 static DartDebugServer& shared();
48 static void intitialize(); 48 static void intitialize();
49 49
50 void registerIsolate(Dart_Isolate); 50 void registerIsolate(Dart_Isolate);
51 void unregisterIsolate(Dart_Isolate); 51 void unregisterIsolate(Dart_Isolate);
52 52
53 void isolateLoaded(); 53 void isolateLoaded();
54 54
55 void disable(); 55 void disable();
56 56
57 static v8::Handle<v8::Value> convertInspectedValue(Dart_Handle object);
58
59 private: 57 private:
60 DartDebugServer(); 58 DartDebugServer();
61 59
62 v8::Handle<v8::Object> createExecutionState(Dart_StackTrace); 60 v8::Handle<v8::Object> createExecutionState(Dart_StackTrace);
63 61
64 static void breakpointHandler(Dart_IsolateId isolate_id, Dart_Breakpoint, Da rt_StackTrace); 62 static void breakpointHandler(Dart_IsolateId isolate_id, Dart_Breakpoint, Da rt_StackTrace);
65 void handleBreakpoint(Dart_Breakpoint, Dart_StackTrace); 63 void handleBreakpoint(Dart_Breakpoint, Dart_StackTrace);
66 64
67 static void exceptionHandler(Dart_IsolateId isolate_id, Dart_Handle, Dart_St ackTrace); 65 static void exceptionHandler(Dart_IsolateId isolate_id, Dart_Handle, Dart_St ackTrace);
68 void handleException(Dart_Handle, Dart_StackTrace); 66 void handleException(Dart_Handle, Dart_StackTrace);
69 67
70 void ensureHooksInstalled(); 68 void ensureHooksInstalled();
71 69
72 ScopedPersistent<v8::Object> m_dartDebugObject; 70 ScopedPersistent<v8::Object> m_dartDebugObject;
73 }; 71 };
74 72
75 } 73 }
76 74
77 #endif // DartDebugServer_h 75 #endif // DartDebugServer_h
OLDNEW
« no previous file with comments | « Source/bindings/dart/DartDebugHooks.js ('k') | Source/bindings/dart/DartDebugServer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698