Improve Dart Debugger performance and robustness by creating Dart wrappers using the standard SetNa…

Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp

 /*
  * Copyright (C) 2007-2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 27 matching lines @@
 #include "V8Int16Array.h"
 #include "V8Int32Array.h"
 #include "V8Int8Array.h"
 #include "V8Node.h"
 #include "V8NodeList.h"
 #include "V8Storage.h"
 #include "V8Uint16Array.h"
 #include "V8Uint32Array.h"
 #include "V8Uint8Array.h"
 #include "V8Uint8ClampedArray.h"
+#include "bindings/dart/DartHandleProxy.h"
 #include "bindings/tests/results/V8Float64Array.h"
 #include "bindings/v8/BindingSecurity.h"
 #include "bindings/v8/ScriptDebugServer.h"
 #include "bindings/v8/ScriptValue.h"
 #include "bindings/v8/V8AbstractEventListener.h"
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/V8HiddenPropertyName.h"
 #include "bindings/v8/V8ScriptRunner.h"
 #include "core/inspector/InjectedScript.h"
 #include "core/inspector/InjectedScriptHost.h"
 #include "core/inspector/InspectorDOMAgent.h"
 #include "core/inspector/InspectorValues.h"
 #include "modules/webdatabase/Database.h"
 
 namespace WebCore {
 
 Node* InjectedScriptHost::scriptValueAsNode(ScriptValue value)
 {
+    v8::HandleScope scope;
     if (!value.isObject() || value.isNull())
         return 0;
-    return V8Node::toNative(v8::Handle<v8::Object>::Cast(value.v8ValueRaw()));
+
+    v8::Handle<v8::Object> handle = v8::Handle<v8::Object>::Cast(value.v8ValueRaw());

[Anton Muhin, 2013/07/16 13:27:40]

it might be not a restriction now, but we tried really hard not to mess up with
v8 bindings.

[Jacob, 2013/07/16 16:44:59]

My impression is that restriction has been lifted a bit now and we should try to
implement things the right way as much as possible versus leaving the v8
bindings completely frozen.

+    if (DartHandleProxy::isDartProxy(handle))
+        return DartHandleProxy::toNativeNode(handle);
+
+    return V8Node::toNative(handle);
 }
 
 ScriptValue InjectedScriptHost::nodeAsScriptValue(ScriptState* state, Node* node)
 {
     v8::HandleScope scope;
     v8::Local<v8::Context> context = state->context();
     v8::Context::Scope contextScope(context);
 
     if (!BindingSecurity::shouldAllowAccessToNode(node))
         return ScriptValue(v8::Null());
@@ skipping 91 matching lines @@
         return;
     }
     if (V8Float32Array::HasInstance(value, args.GetIsolate(), currentWorldType) || V8Float64Array::HasInstance(value, args.GetIsolate(), currentWorldType)) {
         v8SetReturnValue(args, v8::String::NewSymbol("array"));
         return;
     }
     if (V8Uint8ClampedArray::HasInstance(value, args.GetIsolate(), currentWorldType)) {
         v8SetReturnValue(args, v8::String::NewSymbol("array"));
         return;
     }
+    if (DartHandleProxy::isDartProxy(value)) {
+        const char* type = DartHandleProxy::getType(value);
+        if (type)
+            v8SetReturnValue(args, v8::String::NewSymbol(type));
+        return;
+    }
 }
 
 void V8InjectedScriptHost::functionDetailsMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
 {
     if (args.Length() < 1)
         return;
 
     v8::Handle<v8::Value> value = args[0];
     if (!value->IsFunction())
         return;
@@ skipping 169 matching lines @@
     v8::Handle<v8::Value> newValue = args[3];
 
     InjectedScriptHost* host = V8InjectedScriptHost::toNative(args.Holder());
     ScriptDebugServer& debugServer = host->scriptDebugServer();
     v8SetReturnValue(args, debugServer.setFunctionVariableValue(functionValue, scopeIndex, variableName, newValue));
 }
 
 
 } // namespace WebCore