Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1816883002: Refactor 4f gradients using trait templates (Closed)

Created:
4 years, 9 months ago by f(malita)
Modified:
4 years, 9 months ago
Reviewers:
herb_g, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Refactor 4f gradients using trait templates Some 4f gradient housekeeping. 1) replace <DstPtrType, ColorProfile> specialization tuples with an enum covering all dest types (L32, S32, F16, F32) 2) group various template helpers into dest trait classes, specialized for each dest type (2a - conflate current dst_swizzle and scale_for_dest ops into one load op) R=reed@google.com,mtklein@google.com,herb@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1816883002 Committed: https://skia.googlesource.com/skia/+/dc6c9bf91c158e89cd9d5ef19dfbf1da98c598a6

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -221 lines) Patch
M src/effects/gradients/Sk4fGradientBase.h View 1 chunk +7 lines, -5 lines 0 comments Download
M src/effects/gradients/Sk4fGradientBase.cpp View 1 2 3 3 chunks +16 lines, -16 lines 0 comments Download
M src/effects/gradients/Sk4fGradientPriv.h View 1 2 3 3 chunks +141 lines, -89 lines 0 comments Download
M src/effects/gradients/Sk4fLinearGradient.h View 1 chunk +7 lines, -5 lines 0 comments Download
M src/effects/gradients/Sk4fLinearGradient.cpp View 1 2 3 12 chunks +40 lines, -106 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
f(malita)
4 years, 9 months ago (2016-03-21 15:14:30 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816883002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816883002/60001
4 years, 9 months ago (2016-03-21 15:14:54 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-21 15:27:06 UTC) #9
reed1
lgtm
4 years, 9 months ago (2016-03-21 16:31:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816883002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816883002/60001
4 years, 9 months ago (2016-03-21 20:16:01 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 20:16:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/dc6c9bf91c158e89cd9d5ef19dfbf1da98c598a6

Powered by Google App Engine
This is Rietveld 408576698