Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1816843002: Remove a static initializer in region.cpp (Closed)

Created:
4 years, 9 months ago by jungshik at Google
Modified:
4 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove a static initializer in region.cpp region.cpp has an unnecessary static initializer for a type UnicodeString and triggers a 'si check' failure. Upstream bug: http://bugs.icu-project.org/trac/ticket/12408 BUG=575007 TEST=`tools/linux/dump-static-initializers.py chrome` (static build) does not have an entry from region.cpp TEST=`tools/linux/dump-static-initializers.py libicui18n.so` (shared build) has no entry. TBR=thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/0d572d65aae621e13d6863fe470c9c8cee71043d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -6 lines) Patch
M README.chromium View 2 chunks +6 lines, -2 lines 0 comments Download
A patches/remove_si.patch View 1 chunk +69 lines, -0 lines 0 comments Download
M source/i18n/region.cpp View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
jungshik at Google
4 years, 9 months ago (2016-03-20 07:23:56 UTC) #4
jungshik at Google
Committed patchset #1 (id:1) manually as 0d572d65aae621e13d6863fe470c9c8cee71043d (presubmit successful).
4 years, 9 months ago (2016-03-20 07:24:44 UTC) #6
Nico
4 years, 9 months ago (2016-03-20 23:15:03 UTC) #7
Message was sent while issue was closed.
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698