JSONStream and tests

runtime/vm/json_stream.h

+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#ifndef VM_JSON_STREAM_H_
+#define VM_JSON_STREAM_H_
+
+#include "platform/json.h"
+
+namespace dart {
+
+
+class JSONStream : ValueObject {
+ public:
+  explicit JSONStream(TextBuffer* buffer);
+  ~JSONStream();
+
+  void Clear();

[Ivan Posva, 2013/07/01 23:18:14]

When do you expect to ever have to call Clear() on a currently existing
JSONStream?

[Cutch, 2013/07/01 23:33:55]

Possibly never. I can remove this.

+
+  void OpenObject();
+  void CloseObject();
+
+  void OpenArray();
+  void CloseArray();
+
+  void PrintValueBool(bool b);
+  void PrintValue(int i);
+  void PrintValue(double d);
+  void PrintValue(const char* s);
+
+  void PrintPropertyBool(const char* name, bool b);
+  void PrintProperty(const char* name, int i);
+  void PrintProperty(const char* name, double d);
+  void PrintProperty(const char* name, const char* s);
+
+  void PrintPropertyName(const char* name);

[Ivan Posva, 2013/07/01 23:18:14]

Shouldn't this be a private?

[Cutch, 2013/07/01 23:33:55]

Not without a change to OpenObject.  This is needed for outputting child
objects, for example:

OpenObject(); // outputs {
PrintPropertyName("childObject"); // outputs "childObject":
OpenObject(); // outputs {
CloseObject(); // outputs }
CloseObject(); // outputs }

I can make this private and modify OpenObject to take the (optional) name of the
child object.

+
+ private:
+  void PrintCommaIfNeeded();
+  bool NeedComma();
+  intptr_t open_objects_;
+  TextBuffer* buffer_;
+};
+
+}  // namespace dart
+
+#endif  // VM_JSON_STREAM_H_