Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1816713002: base: Remove scoped_refptr unwrapping for Bind arguments. (Closed)

Created:
4 years, 9 months ago by vmpstr
Modified:
4 years, 9 months ago
Reviewers:
danakj, Nico, tzik
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Remove scoped_refptr unwrapping for Bind arguments. This patch removes scoped_refptr unwrapping for general Bind parameters. Note that the only parameter that is still unwrapped is the first one if it's an object on which the method is called. Please see the bug for more context. R=tzik@chromium.org, thakis@chromium.org, danakj@chromium.org BUG=589048 Committed: https://crrev.com/56b73909564351265f07ee76aa5972461e12c070 Cr-Commit-Position: refs/heads/master@{#382730}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M base/bind_helpers.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M base/bind_internal.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
vmpstr
Please take a look. This depends on https://codereview.chromium.org/1815363002
4 years, 9 months ago (2016-03-18 22:39:23 UTC) #1
Nico
lgtm
4 years, 9 months ago (2016-03-18 22:46:04 UTC) #2
tzik
lgtm
4 years, 9 months ago (2016-03-19 10:14:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816713002/40001
4 years, 9 months ago (2016-03-21 20:54:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/147680)
4 years, 9 months ago (2016-03-21 21:02:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816713002/40001
4 years, 9 months ago (2016-03-22 19:47:33 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-22 23:34:02 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 23:36:06 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/56b73909564351265f07ee76aa5972461e12c070
Cr-Commit-Position: refs/heads/master@{#382730}

Powered by Google App Engine
This is Rietveld 408576698