Issue 1816693002: Extract CacheStorage and renames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1816693002: Extract CacheStorage and renames. (Closed)

Created:
4 years, 9 months ago by scheglov

Modified:
4 years, 9 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Extract CacheStorage and renames. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/fb5c63d00c77bda2d6fbbb41cef35567a26af2c8

Patch Set 1 #

Total comments: 1

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -51 lines)			Patch
	M	pkg/analyzer/lib/src/summary/incremental_cache.dart	View		7 chunks	+71 lines, -44 lines	1 comment	Download
	M	pkg/analyzer/test/src/summary/incremental_cache_test.dart	View		3 chunks	+22 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

lgtm assuming the issue below is addressed. https://codereview.chromium.org/1816693002/diff/1/pkg/analyzer/lib/src/summary/incremental_cache.dart File pkg/analyzer/lib/src/summary/incremental_cache.dart (right): https://codereview.chromium.org/1816693002/diff/1/pkg/analyzer/lib/src/summary/incremental_cache.dart#newcode70 pkg/analyzer/lib/src/summary/incremental_cache.dart:70: try { ...

4 years, 9 months ago (2016-03-18 20:22:42 UTC) #2

scheglov

4 years, 9 months ago (2016-03-18 20:41:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fb5c63d00c77bda2d6fbbb41cef35567a26af2c8 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages