Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1816653002: Remove app_remoting. (Closed)

Created:
4 years, 9 months ago by Sergey Ulanov
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, garykac
CC:
chromium-reviews, dcheng, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove app_remoting. Removed all files used to build app_remoting webapp and cleaned up build files. Committed: https://crrev.com/6f7cb3e3bee26214c15a365552462cd8d0719677 Cr-Commit-Position: refs/heads/master@{#382147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4654 lines) Patch
M build/gn_migration.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D remoting/app_remoting_shared_module.gyp View 1 chunk +0 lines, -223 lines 0 comments Download
D remoting/app_remoting_webapp.gyp View 1 chunk +0 lines, -42 lines 0 comments Download
D remoting/app_remoting_webapp_build.gypi View 1 chunk +0 lines, -149 lines 0 comments Download
D remoting/app_remoting_webapp_compile.gypi View 1 chunk +0 lines, -45 lines 0 comments Download
D remoting/app_remoting_webapp_files.gypi View 1 chunk +0 lines, -131 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +1 line, -3 lines 0 comments Download
M remoting/remoting_all.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M remoting/remoting_client.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/remoting_test.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/remoting_webapp.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/webapp/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D remoting/webapp/app_remoting/apps/sample_app/icon128.png View Binary file 0 comments Download
D remoting/webapp/app_remoting/apps/sample_app/icon16.png View Binary file 0 comments Download
D remoting/webapp/app_remoting/apps/sample_app/icon48.png View Binary file 0 comments Download
D remoting/webapp/app_remoting/apps/sample_app/loading_splash.png View Binary file 0 comments Download
D remoting/webapp/app_remoting/apps/sample_app/manifest.json.jinja2 View 1 chunk +0 lines, -3 lines 0 comments Download
D remoting/webapp/app_remoting/html/ar_dialog.css View 1 chunk +0 lines, -15 lines 0 comments Download
D remoting/webapp/app_remoting/html/ar_main.css View 1 chunk +0 lines, -8 lines 0 comments Download
D remoting/webapp/app_remoting/html/cloud_print_dialog.css View 1 chunk +0 lines, -14 lines 0 comments Download
D remoting/webapp/app_remoting/html/context_menu.css View 1 chunk +0 lines, -125 lines 0 comments Download
D remoting/webapp/app_remoting/html/context_menu.html View 1 chunk +0 lines, -15 lines 0 comments Download
D remoting/webapp/app_remoting/html/feedback_consent.css View 1 chunk +0 lines, -26 lines 0 comments Download
D remoting/webapp/app_remoting/html/idle_dialog.html View 1 chunk +0 lines, -10 lines 0 comments Download
D remoting/webapp/app_remoting/html/loading_window.css View 1 chunk +0 lines, -40 lines 0 comments Download
D remoting/webapp/app_remoting/html/template_background.html View 1 chunk +0 lines, -18 lines 0 comments Download
D remoting/webapp/app_remoting/html/template_feedback_consent.html View 1 chunk +0 lines, -76 lines 0 comments Download
D remoting/webapp/app_remoting/html/template_lg.html View 1 chunk +0 lines, -52 lines 0 comments Download
D remoting/webapp/app_remoting/html/template_loading_window.html View 1 chunk +0 lines, -31 lines 0 comments Download
D remoting/webapp/app_remoting/js/app_connected_view.js View 1 chunk +0 lines, -277 lines 0 comments Download
D remoting/webapp/app_remoting/js/app_remoting.js View 1 chunk +0 lines, -140 lines 0 comments Download
D remoting/webapp/app_remoting/js/app_remoting_activity.js View 1 chunk +0 lines, -274 lines 0 comments Download
D remoting/webapp/app_remoting/js/application_context_menu.js View 1 chunk +0 lines, -150 lines 0 comments Download
D remoting/webapp/app_remoting/js/ar_auth_dialog.js View 1 chunk +0 lines, -56 lines 0 comments Download
D remoting/webapp/app_remoting/js/ar_background.js View 1 chunk +0 lines, -79 lines 0 comments Download
D remoting/webapp/app_remoting/js/cloud_print_dialog/cloud_print_dialog_injected.js View 1 chunk +0 lines, -58 lines 0 comments Download
D remoting/webapp/app_remoting/js/cloud_print_dialog_container.js View 1 chunk +0 lines, -331 lines 0 comments Download
D remoting/webapp/app_remoting/js/context_menu_adapter.js View 1 chunk +0 lines, -59 lines 0 comments Download
D remoting/webapp/app_remoting/js/context_menu_chrome.js View 1 chunk +0 lines, -96 lines 0 comments Download
D remoting/webapp/app_remoting/js/context_menu_dom.js View 1 chunk +0 lines, -314 lines 0 comments Download
D remoting/webapp/app_remoting/js/drag_and_drop.js View 1 chunk +0 lines, -120 lines 0 comments Download
D remoting/webapp/app_remoting/js/feedback_consent.js View 1 chunk +0 lines, -272 lines 0 comments Download
D remoting/webapp/app_remoting/js/gaia_license_manager.js View 1 chunk +0 lines, -38 lines 0 comments Download
D remoting/webapp/app_remoting/js/idle_detector.js View 1 chunk +0 lines, -154 lines 0 comments Download
D remoting/webapp/app_remoting/js/keyboard_layouts_menu.js View 1 chunk +0 lines, -184 lines 0 comments Download
D remoting/webapp/app_remoting/js/license_manager.js View 1 chunk +0 lines, -47 lines 0 comments Download
D remoting/webapp/app_remoting/js/loading_window.js View 1 chunk +0 lines, -75 lines 0 comments Download
D remoting/webapp/app_remoting/js/submenu_manager.js View 1 chunk +0 lines, -94 lines 0 comments Download
D remoting/webapp/app_remoting/js/window_activation_menu.js View 1 chunk +0 lines, -89 lines 0 comments Download
D remoting/webapp/app_remoting/manifest_common.json.jinja2 View 1 chunk +0 lines, -71 lines 0 comments Download
D remoting/webapp/app_remoting/shared_module/manifest.json View 1 chunk +0 lines, -8 lines 0 comments Download
D remoting/webapp/app_remoting/vendor/arv_background.html View 1 chunk +0 lines, -2 lines 0 comments Download
D remoting/webapp/app_remoting/vendor/arv_main.html View 1 chunk +0 lines, -13 lines 0 comments Download
D remoting/webapp/app_remoting/vendor/arv_main.js View 1 chunk +0 lines, -27 lines 0 comments Download
D remoting/webapp/app_remoting/vendor/arv_wcs_sandbox.html View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/webapp/build-webapp.py View 10 chunks +35 lines, -135 lines 0 comments Download
M remoting/webapp/build_template.gni View 3 chunks +0 lines, -296 lines 0 comments Download
M remoting/webapp/files.gni View 2 chunks +1 line, -137 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Sergey Ulanov
4 years, 9 months ago (2016-03-18 18:28:21 UTC) #3
garykac
lgtm
4 years, 9 months ago (2016-03-18 21:22:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816653002/1
4 years, 9 months ago (2016-03-18 21:22:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/158778)
4 years, 9 months ago (2016-03-18 21:41:21 UTC) #8
Sergey Ulanov
+dpranke@ for src/build
4 years, 9 months ago (2016-03-18 21:58:41 UTC) #10
Dirk Pranke
lgtm. You could consider linking this to bug 471916 and/or closing that bug as WontFix, ...
4 years, 9 months ago (2016-03-18 22:07:54 UTC) #11
Sergey Ulanov
On 2016/03/18 22:07:54, Dirk Pranke wrote: > lgtm. > > You could consider linking this ...
4 years, 9 months ago (2016-03-18 22:18:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816653002/1
4 years, 9 months ago (2016-03-18 22:19:45 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-19 00:38:14 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 00:39:24 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f7cb3e3bee26214c15a365552462cd8d0719677
Cr-Commit-Position: refs/heads/master@{#382147}

Powered by Google App Engine
This is Rietveld 408576698