Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: content/test/gpu/page_sets/pixel_tests.py

Issue 1816623002: Reenable IOSurface Canvas2D. Disable new trace tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/page_sets/pixel_tests.py
diff --git a/content/test/gpu/page_sets/pixel_tests.py b/content/test/gpu/page_sets/pixel_tests.py
index 3be192aa3afd2a75a077dac7ba4d115a4543357e..1c7da086972d81c7561b09d90916b5b66df2aac1 100644
--- a/content/test/gpu/page_sets/pixel_tests.py
+++ b/content/test/gpu/page_sets/pixel_tests.py
@@ -71,14 +71,16 @@ class PixelTestsStorySet(story_set_module.StorySet):
story_set=self,
shared_page_state_class=IOSurface2DCanvasSharedPageState,
expectations=expectations))
- self.AddStory(PixelTestsPage(
- url='file://../../data/gpu/pixel_canvas2d_webgl.html',
- name=base_name + '.IOSurface2DCanvasWebGL',
- test_rect=[0, 0, 400, 400],
- revision=1,
- story_set=self,
- shared_page_state_class=IOSurface2DCanvasSharedPageState,
- expectations=expectations))
+ # Temporarily disable test to look for source of
+ # trace_test.IOSurface2DCanvas failures. https://crbug.com/595754.
Ken Russell (switch to Gerrit) 2016/03/19 04:27:04 Could you skip this test instead in src/content/te
erikchen 2016/03/21 19:45:03 I skipped the test in trace_test.py, since I want
+ #self.AddStory(PixelTestsPage(
+ # url='file://../../data/gpu/pixel_canvas2d_webgl.html',
+ # name=base_name + '.IOSurface2DCanvasWebGL',
+ # test_rect=[0, 0, 400, 400],
+ # revision=1,
+ # story_set=self,
+ # shared_page_state_class=IOSurface2DCanvasSharedPageState,
+ # expectations=expectations))
def _AddAllPages(self, expectations, base_name, use_es3):
if use_es3:
@@ -125,14 +127,16 @@ class PixelTestsStorySet(story_set_module.StorySet):
expectations=expectations,
expected_colors='../../data/gpu/pixel_scissor_expectations.json'))
- self.AddStory(PixelTestsPage(
- url='file://../../data/gpu/pixel_canvas2d_webgl.html',
- name=base_name + '.2DCanvasWebGL',
- test_rect=[0, 0, 400, 400],
- revision=1,
- story_set=self,
- shared_page_state_class=shared_page_state_class,
- expectations=expectations))
+ # Temporarily disable test to look for source of
+ # trace_test.IOSurface2DCanvas failures. https://crbug.com/595754.
Ken Russell (switch to Gerrit) 2016/03/19 04:27:04 Same here.
+ #self.AddStory(PixelTestsPage(
+ # url='file://../../data/gpu/pixel_canvas2d_webgl.html',
+ # name=base_name + '.2DCanvasWebGL',
+ # test_rect=[0, 0, 400, 400],
+ # revision=1,
+ # story_set=self,
+ # shared_page_state_class=shared_page_state_class,
+ # expectations=expectations))
@property
def allow_mixed_story_states(self):
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698