Reenable IOSurface Canvas2D. Disable new trace tests.

Reenable IOSurface Canvas2D. Disable new trace tests.

Continuing to track down source of trace_test.IOSurface2DCanvas flaky errors.

BUG=595754
Committed: https://crrev.com/bf380d5748bbb3ea2b9f14ea1a721a8a4bab5ace
Cr-Commit-Position: refs/heads/master@{#382482}

[erikchen, 2016-03-18 17:05:45]

erikchen@chromium.org changed reviewers:
+ junov@chromium.org

[erikchen, 2016-03-18 17:05:45]

junov: Please review.

[erikchen, 2016-03-18 17:06:05]

erikchen@chromium.org changed reviewers:
+ kbr@chromium.org

[erikchen, 2016-03-18 17:06:06]

kbr: Please review content/test/gpu/page_sets/pixel_tests.py.

[erikchen, 2016-03-18 18:14:05]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 18:14:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1816623002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1816623002/1

[commit-bot: I haz the power, 2016-03-18 20:12:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 20:12:31]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-03-18 23:39:01]

Patchset #2 (id:20001) has been deleted

[Ken Russell (switch to Gerrit), 2016-03-19 04:27:04]

LGTM but please try the suggestion in pixel_tests.py to retain coverage there,
even if the trace_test version of it is flaky.

https://codereview.chromium.org/1816623002/diff/1/content/test/gpu/page_sets/...
File content/test/gpu/page_sets/pixel_tests.py (right):

https://codereview.chromium.org/1816623002/diff/1/content/test/gpu/page_sets/...
content/test/gpu/page_sets/pixel_tests.py:75: # trace_test.IOSurface2DCanvas
failures. https://crbug.com/595754.
Could you skip this test instead in
src/content/test/gpu/gpu_tests/trace_test_expectations.py ? That would allow the
pixel test to continue to run.

https://codereview.chromium.org/1816623002/diff/1/content/test/gpu/page_sets/...
content/test/gpu/page_sets/pixel_tests.py:131: # trace_test.IOSurface2DCanvas
failures. https://crbug.com/595754.
Same here.

[erikchen, 2016-03-21 19:45:03]

kbr: PTAL

https://codereview.chromium.org/1816623002/diff/1/content/test/gpu/page_sets/...
File content/test/gpu/page_sets/pixel_tests.py (right):

https://codereview.chromium.org/1816623002/diff/1/content/test/gpu/page_sets/...
content/test/gpu/page_sets/pixel_tests.py:75: # trace_test.IOSurface2DCanvas
failures. https://crbug.com/595754.
On 2016/03/19 04:27:04, Ken Russell wrote:
> Could you skip this test instead in
> src/content/test/gpu/gpu_tests/trace_test_expectations.py ? That would allow
the
> pixel test to continue to run.

I skipped the test in trace_test.py, since I want the test to not run, not just
fail.

[Ken Russell (switch to Gerrit), 2016-03-21 21:14:10]

https://codereview.chromium.org/1816623002/diff/40001/content/test/gpu/gpu_te...
File content/test/gpu/gpu_tests/trace_test.py (right):

https://codereview.chromium.org/1816623002/diff/40001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/trace_test.py:97: # story_set.stories = stories
This code is commented out? Don't see how it will have an effect.

To be clear, I'm suggesting making the following change in
src/content/test/gpu/gpu_tests/trace_test_expectations.py:

class TraceTestExpectations(GpuTestExpectations):
  def SetExpectations(self):
    self.Skip('TraceTest.IOSurface2DCanvasWebGL', ['mac'], bug=595754)
    self.Skip(TraceTest.2DCanvasWebGL', bug=595754)

[erikchen, 2016-03-21 21:27:52]

https://codereview.chromium.org/1816623002/diff/40001/content/test/gpu/gpu_te...
File content/test/gpu/gpu_tests/trace_test.py (right):

https://codereview.chromium.org/1816623002/diff/40001/content/test/gpu/gpu_te...
content/test/gpu/gpu_tests/trace_test.py:97: # story_set.stories = stories
On 2016/03/21 21:14:10, Ken Russell wrote:
> This code is commented out? Don't see how it will have an effect.
> 
> To be clear, I'm suggesting making the following change in
> src/content/test/gpu/gpu_tests/trace_test_expectations.py:
> 
> class TraceTestExpectations(GpuTestExpectations):
>   def SetExpectations(self):
>     self.Skip('TraceTest.IOSurface2DCanvasWebGL', ['mac'], bug=595754)
>     self.Skip(TraceTest.2DCanvasWebGL', bug=595754)

I didn't expect to be able to skip running a test from a method that sets
expectations for tests. I've followed your suggestion.

[erikchen, 2016-03-21 21:28:19]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-03-21 21:28:20]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/1816623002/#ps60001
(title: "Comments from kbr.")

[erikchen, 2016-03-21 21:28:32]

Description was changed from

==========
Reenable IOSurface Canvas2D. Disable new pixel tests.

Continuing to track down source of trace_test.IOSurface2DCanvas flaky errors.

BUG=595754
==========

to

==========
Reenable IOSurface Canvas2D. Disable new trace tests.

Continuing to track down source of trace_test.IOSurface2DCanvas flaky errors.

BUG=595754
==========

[erikchen, 2016-03-21 21:28:36]

The CQ bit was unchecked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-03-21 21:28:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1816623002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1816623002/60001

[erikchen, 2016-03-21 21:28:40]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-03-21 21:29:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1816623002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1816623002/60001

[commit-bot: I haz the power, 2016-03-21 21:39:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 21:39:21]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-03-21 21:50:38]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-03-21 21:50:38]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/1816623002/#ps80001
(title: "Rebase error.")

[commit-bot: I haz the power, 2016-03-21 21:51:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1816623002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1816623002/80001

[commit-bot: I haz the power, 2016-03-21 21:53:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 21:53:26]

Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[erikchen, 2016-03-21 22:06:36]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-03-21 22:06:37]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/1816623002/#ps100001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-03-21 22:07:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1816623002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1816623002/100001

[commit-bot: I haz the power, 2016-03-21 22:16:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 22:16:41]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[erikchen, 2016-03-21 22:31:40]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-03-21 22:31:40]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/1816623002/#ps120001
(title: "Rebase, again.")

[commit-bot: I haz the power, 2016-03-21 22:32:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1816623002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1816623002/120001

[commit-bot: I haz the power, 2016-03-21 22:34:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 22:34:53]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[erikchen, 2016-03-21 23:05:30]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-03-21 23:05:31]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/1816623002/#ps80002
(title: "Continue to rebase.")

[commit-bot: I haz the power, 2016-03-21 23:06:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1816623002/80002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1816623002/80002

[commit-bot: I haz the power, 2016-03-22 02:52:44]

Description was changed from

==========
Reenable IOSurface Canvas2D. Disable new trace tests.

Continuing to track down source of trace_test.IOSurface2DCanvas flaky errors.

BUG=595754
==========

to

==========
Reenable IOSurface Canvas2D. Disable new trace tests.

Continuing to track down source of trace_test.IOSurface2DCanvas flaky errors.

BUG=595754
==========

[commit-bot: I haz the power, 2016-03-22 02:52:46]

Committed patchset #7 (id:80002)

[commit-bot: I haz the power, 2016-03-22 02:53:42]

Description was changed from

==========
Reenable IOSurface Canvas2D. Disable new trace tests.

Continuing to track down source of trace_test.IOSurface2DCanvas flaky errors.

BUG=595754
==========

to

==========
Reenable IOSurface Canvas2D. Disable new trace tests.

Continuing to track down source of trace_test.IOSurface2DCanvas flaky errors.

BUG=595754

Committed: https://crrev.com/bf380d5748bbb3ea2b9f14ea1a721a8a4bab5ace
Cr-Commit-Position: refs/heads/master@{#382482}
==========

[commit-bot: I haz the power, 2016-03-22 02:53:44]

Patchset 7 (id:??) landed as
https://crrev.com/bf380d5748bbb3ea2b9f14ea1a721a8a4bab5ace
Cr-Commit-Position: refs/heads/master@{#382482}