Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1816593002: Remove js interop side-cast test suppression (Closed)

Created:
4 years, 9 months ago by Alan Knight
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove js interop side-cast test suppression BUG= Committed: https://github.com/dart-lang/sdk/commit/ca924d09d14e54133c1d52c8da1aece6240cd5e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tests/html/html.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Alan Knight
This started working with the fix to VttCue.line TBR
4 years, 9 months ago (2016-03-18 16:11:04 UTC) #2
Alan Knight
Committed patchset #1 (id:1) manually as ca924d09d14e54133c1d52c8da1aece6240cd5e6 (presubmit successful).
4 years, 9 months ago (2016-03-18 16:11:38 UTC) #4
Siggi Cherem (dart-lang)
4 years, 9 months ago (2016-03-18 16:19:57 UTC) #5
Message was sent while issue was closed. 
lgtm

thanks!

Powered by Google App Engine
This is Rietveld 408576698