src/base/platform/platform-posix.cc - Issue 1816583003: wasm: add flag to dump modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/base/platform/platform-posix.cc

Issue 1816583003: wasm: add flag to dump modules (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/base/platform/platform-posix.cc

diff --git a/src/base/platform/platform-posix.cc b/src/base/platform/platform-posix.cc

index 7e985e3fb70bc68bcc3c16789db9179dac7d298c..bb340ab5f95af47f8c455e91ceeb1c182c8d7434 100644

--- a/src/base/platform/platform-posix.cc

+++ b/src/base/platform/platform-posix.cc

@@ -429,9 +429,10 @@ bool OS::Remove(const char* path) {

return (remove(path) == 0);

}

+char OS::DirectorySeparator() { return '/'; }

bool OS::isDirectorySeparator(const char ch) {

- return ch == '/';

+ return ch == DirectorySeparator();

bradnelson 2016/03/19 00:57:11 Your trust in the compiler astounds me :-)

JF 2016/03/19 01:04:48 ? Comparing two chars?

}