PlzNavigate: fix SecurityExploitBrowserTest.MismatchedOriginOnCommit

PlzNavigate: fix SecurityExploitBrowserTest.MismatchedOriginOnCommit

This CL fixes SecurityExploitBrowserTest.MismatchedOriginOnCommit. Due to a
difference in how teh main resource request are made, a network request was
still present when the test is destroyed. This request finishes and try to
access teh StallDelegate which has already been destroyed. Resetting the
ResourceDispatcherHostDelegate before destroying the test fixes that.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/eeb96fdeecafcd7f6c88a87bfd2bfa8b7f12c94c
Cr-Commit-Position: refs/heads/master@{#382833}

[clamy, 2016-03-18 14:25:21]

Description was changed from

==========
PlzNavigate: fix SecurityExploitBrowserTest.MismatchedOriginOnCommit

This CL fixes SecurityExploitBrowserTest.MismatchedOriginOnCommit. Due to a
difference in how teh main resource request are made, a network request was
still present when the test is destroyed. This request finishes and try to
access teh StallDelegate which has already been destroyed. Resetting the
ResourceDispatcherHostDelegate before destroying the test fixes that.

BUG=475027
==========

to

==========
PlzNavigate: fix SecurityExploitBrowserTest.MismatchedOriginOnCommit

This CL fixes SecurityExploitBrowserTest.MismatchedOriginOnCommit. Due to a
difference in how teh main resource request are made, a network request was
still present when the test is destroyed. This request finishes and try to
access teh StallDelegate which has already been destroyed. Resetting the
ResourceDispatcherHostDelegate before destroying the test fixes that.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-03-18 14:25:58]

Description was changed from

==========
PlzNavigate: fix SecurityExploitBrowserTest.MismatchedOriginOnCommit

This CL fixes SecurityExploitBrowserTest.MismatchedOriginOnCommit. Due to a
difference in how teh main resource request are made, a network request was
still present when the test is destroyed. This request finishes and try to
access teh StallDelegate which has already been destroyed. Resetting the
ResourceDispatcherHostDelegate before destroying the test fixes that.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: fix SecurityExploitBrowserTest.MismatchedOriginOnCommit

This CL fixes SecurityExploitBrowserTest.MismatchedOriginOnCommit. Due to a
difference in how teh main resource request are made, a network request was
still present when the test is destroyed. This request finishes and try to
access teh StallDelegate which has already been destroyed. Resetting the
ResourceDispatcherHostDelegate before destroying the test fixes that.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-03-18 14:25:58]

clamy@chromium.org changed reviewers:
+ nasko@chromium.org

[clamy, 2016-03-18 14:26:12]

@nasko:PTAL

[nasko, 2016-03-18 20:41:14]

https://codereview.chromium.org/1816563002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/1816563002/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_impl.cc:1018:
stream_handle_.reset();
Instead of putting these in all cases where we kill the renderer, why not
include the code in ::RenderProcessGone? This will be a good catch all and less
prone to people forgetting to add this call.

[clamy, 2016-03-22 16:46:56]

Thanks!

https://codereview.chromium.org/1816563002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/1816563002/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_impl.cc:1018:
stream_handle_.reset();
On 2016/03/18 20:41:14, nasko (slow) wrote:
> Instead of putting these in all cases where we kill the renderer, why not
> include the code in ::RenderProcessGone? This will be a good catch all and
less
> prone to people forgetting to add this call.

Actually we already do (in the SiteInstance version which calls
ResetLoadingState). Removed those calls.

[nasko, 2016-03-22 23:04:15]

LGTM

[clamy, 2016-03-23 10:58:26]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2016-03-23 10:58:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1816563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1816563002/40001

[commit-bot: I haz the power, 2016-03-23 12:31:54]

Description was changed from

==========
PlzNavigate: fix SecurityExploitBrowserTest.MismatchedOriginOnCommit

This CL fixes SecurityExploitBrowserTest.MismatchedOriginOnCommit. Due to a
difference in how teh main resource request are made, a network request was
still present when the test is destroyed. This request finishes and try to
access teh StallDelegate which has already been destroyed. Resetting the
ResourceDispatcherHostDelegate before destroying the test fixes that.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: fix SecurityExploitBrowserTest.MismatchedOriginOnCommit

This CL fixes SecurityExploitBrowserTest.MismatchedOriginOnCommit. Due to a
difference in how teh main resource request are made, a network request was
still present when the test is destroyed. This request finishes and try to
access teh StallDelegate which has already been destroyed. Resetting the
ResourceDispatcherHostDelegate before destroying the test fixes that.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-03-23 12:31:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-23 12:33:19]

Description was changed from

==========
PlzNavigate: fix SecurityExploitBrowserTest.MismatchedOriginOnCommit

This CL fixes SecurityExploitBrowserTest.MismatchedOriginOnCommit. Due to a
difference in how teh main resource request are made, a network request was
still present when the test is destroyed. This request finishes and try to
access teh StallDelegate which has already been destroyed. Resetting the
ResourceDispatcherHostDelegate before destroying the test fixes that.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: fix SecurityExploitBrowserTest.MismatchedOriginOnCommit

This CL fixes SecurityExploitBrowserTest.MismatchedOriginOnCommit. Due to a
difference in how teh main resource request are made, a network request was
still present when the test is destroyed. This request finishes and try to
access teh StallDelegate which has already been destroyed. Resetting the
ResourceDispatcherHostDelegate before destroying the test fixes that.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/eeb96fdeecafcd7f6c88a87bfd2bfa8b7f12c94c
Cr-Commit-Position: refs/heads/master@{#382833}
==========

[commit-bot: I haz the power, 2016-03-23 12:33:20]

Patchset 3 (id:??) landed as
https://crrev.com/eeb96fdeecafcd7f6c88a87bfd2bfa8b7f12c94c
Cr-Commit-Position: refs/heads/master@{#382833}