src/x64/code-stubs-x64.cc - Issue 1816553002: Introduce a code stub version of Array.prototype.push

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/code-stubs-x64.cc

Issue 1816553002: Introduce a code stub version of Array.prototype.push (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Cleanup Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/code-stubs-x64.cc

diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc

index 15d0f0e8079032b5c1dfc849efeae36eaac41091..45e4f7e6bc1c83f87aaebe30f8866d8a8b8d60e2 100644

--- a/src/x64/code-stubs-x64.cc

+++ b/src/x64/code-stubs-x64.cc

@@ -76,6 +76,10 @@ void InternalArrayNoArgumentConstructorStub::InitializeDescriptor(

InitializeInternalArrayConstructorDescriptor(isolate(), descriptor, 0);

}

+void FastArrayPushStub::InitializeDescriptor(CodeStubDescriptor* descriptor) {

+ Address deopt_handler = Runtime::FunctionForId(Runtime::kArrayPush)->entry;

+ descriptor->Initialize(rax, deopt_handler, -1, JS_FUNCTION_STUB_MODE);

void InternalArraySingleArgumentConstructorStub::InitializeDescriptor(

CodeStubDescriptor* descriptor) {