Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: src/objects-inl.h

Issue 1816553002: Introduce a code stub version of Array.prototype.push (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 5795 matching lines...) Expand 10 before | Expand all | Expand 10 after
5806 if (src_str->IsOneByteRepresentation()) { 5806 if (src_str->IsOneByteRepresentation()) {
5807 return ExternalOneByteString::cast(src)->resource() != NULL; 5807 return ExternalOneByteString::cast(src)->resource() != NULL;
5808 } else if (src_str->IsTwoByteRepresentation()) { 5808 } else if (src_str->IsTwoByteRepresentation()) {
5809 return ExternalTwoByteString::cast(src)->resource() != NULL; 5809 return ExternalTwoByteString::cast(src)->resource() != NULL;
5810 } 5810 }
5811 return true; 5811 return true;
5812 } 5812 }
5813 5813
5814 5814
5815 void SharedFunctionInfo::DontAdaptArguments() { 5815 void SharedFunctionInfo::DontAdaptArguments() {
5816 DCHECK(code()->kind() == Code::BUILTIN); 5816 DCHECK(code()->kind() == Code::BUILTIN || code()->kind() == Code::STUB);
5817 set_internal_formal_parameter_count(kDontAdaptArgumentsSentinel); 5817 set_internal_formal_parameter_count(kDontAdaptArgumentsSentinel);
5818 } 5818 }
5819 5819
5820 5820
5821 int SharedFunctionInfo::start_position() const { 5821 int SharedFunctionInfo::start_position() const {
5822 return start_position_and_type() >> kStartPositionShift; 5822 return start_position_and_type() >> kStartPositionShift;
5823 } 5823 }
5824 5824
5825 5825
5826 void SharedFunctionInfo::set_start_position(int start_position) { 5826 void SharedFunctionInfo::set_start_position(int start_position) {
(...skipping 1978 matching lines...) Expand 10 before | Expand all | Expand 10 after
7805 #undef WRITE_INT64_FIELD 7805 #undef WRITE_INT64_FIELD
7806 #undef READ_BYTE_FIELD 7806 #undef READ_BYTE_FIELD
7807 #undef WRITE_BYTE_FIELD 7807 #undef WRITE_BYTE_FIELD
7808 #undef NOBARRIER_READ_BYTE_FIELD 7808 #undef NOBARRIER_READ_BYTE_FIELD
7809 #undef NOBARRIER_WRITE_BYTE_FIELD 7809 #undef NOBARRIER_WRITE_BYTE_FIELD
7810 7810
7811 } // namespace internal 7811 } // namespace internal
7812 } // namespace v8 7812 } // namespace v8
7813 7813
7814 #endif // V8_OBJECTS_INL_H_ 7814 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698