LayoutTests/compositing/clip-change.html - Issue 181653006: Remove testRunner.display() from most compositing/ tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/compositing/clip-change.html

Issue 181653006: Remove testRunner.display() from most compositing/ tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Revert change to plugin test Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/compositing/animation/state-at-end-event-transform-layer.html ('k') | LayoutTests/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/compositing/clip-change.html

diff --git a/LayoutTests/compositing/clip-change.html b/LayoutTests/compositing/clip-change.html

index da4a61b288baac53d0ca91001d88dd64d2c23ca4..1cda32b1cc8b38f1b14f0b5bb7fbe90bb1ee4176 100644

--- a/LayoutTests/compositing/clip-change.html

+++ b/LayoutTests/compositing/clip-change.html

@@ -1,6 +1,7 @@

<!DOCTYPE html>

<html>

<head>

+ <script src="../resources/run-after-display.js"></script>

<style>

#indicator {

position: absolute;

@@ -22,16 +23,20 @@

}

</style>

- if (window.testRunner)

+ if (window.testRunner) {

testRunner.dumpAsTextWithPixelResults();

+ testRunner.waitUntilDone();

+ }

function doTest() {

- if (window.testRunner)

- testRunner.display();

- // The change in clip style should be reflected immediately in the size

- // of the composited clipper layer. After changing the clip, it should

- // entirely cover the indicator.

- var clipper = document.getElementById("clipper");

- clipper.style.clip = "rect(0px, 100px, 100px, 0px)";

+ runAfterDisplay(function() {

+ // The change in clip style should be reflected immediately in the size

+ // of the composited clipper layer. After changing the clip, it should

+ // entirely cover the indicator.

+ var clipper = document.getElementById("clipper");

+ clipper.style.clip = "rect(0px, 100px, 100px, 0px)";

+ if (window.testRunner)

+ testRunner.notifyDone();

+ });

}

window.addEventListener("load", doTest, false);

</script>