Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1816513002: [compiler] Remove redundant unoptimized compile trigger. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove redundant unoptimized compile trigger. The trigger point in question is by now obsolete. The optimized compile job will itself ensure that deoptimization support is present on the incoming SharedFunctionInfo, this will make sure to produce baseline code when necessary. The ScopeInfo is also installed at that point in time. R=yangguo@chromium.org Committed: https://crrev.com/8ba35e73ba62a41799dd56942b7b374c20dacac9 Cr-Commit-Position: refs/heads/master@{#34887}

Patch Set 1 #

Patch Set 2 : Test no longer failing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -17 lines) Patch
M src/compiler.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-18 11:04:15 UTC) #1
Yang
On 2016/03/18 11:04:15, Michael Starzinger wrote: lgtm.
4 years, 9 months ago (2016-03-18 11:07:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816513002/20001
4 years, 9 months ago (2016-03-18 12:06:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-18 12:08:34 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 12:09:38 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ba35e73ba62a41799dd56942b7b374c20dacac9
Cr-Commit-Position: refs/heads/master@{#34887}

Powered by Google App Engine
This is Rietveld 408576698