Resolves crash in device notifier for audio input on Mac OS X

Resolves crash in device notifier for audio input on Mac OS X

BUG=596000
Committed: https://crrev.com/6d1646cef28a7d0bf51a1ddf1b6cf20161719799
Cr-Commit-Position: refs/heads/master@{#381931}

[henrika (OOO until Aug 14), 2016-03-18 09:01:59]

Description was changed from

==========
Resolves crash in device notifier for audio input on Mac OS X

BUG=
==========

to

==========
Resolves crash in device notifier for audio input on Mac OS X

BUG=596000
==========

[henrika (OOO until Aug 14), 2016-03-18 09:31:55]

henrika@chromium.org changed reviewers:
+ tommi@chromium.org

[henrika (OOO until Aug 14), 2016-03-18 09:31:56]

Tommi, PTAL

PS, have not been able to cause a crash with this change. Seems to work well.

[tommi (sloooow) - chröme, 2016-03-18 10:08:18]

https://codereview.chromium.org/1816483002/diff/40001/media/audio/mac/audio_l...
File media/audio/mac/audio_low_latency_input_mac.cc (right):

https://codereview.chromium.org/1816483002/diff/40001/media/audio/mac/audio_l...
media/audio/mac/audio_low_latency_input_mac.cc:946:
properties.push_back(property);
you can do this in loop in 2 lines:

for (UInt32 i = 0; i < num_addresses; ++i)
  properties.push_back(addresses[i].mSelector)

https://codereview.chromium.org/1816483002/diff/40001/media/audio/mac/audio_m...
File media/audio/mac/audio_manager_mac.cc (right):

https://codereview.chromium.org/1816483002/diff/40001/media/audio/mac/audio_m...
media/audio/mac/audio_manager_mac.cc:345: DVLOG(1) << "----------------------
OnSuspend";
intended for checkin?

https://codereview.chromium.org/1816483002/diff/40001/media/audio/mac/audio_m...
media/audio/mac/audio_manager_mac.cc:351: DVLOG(1) << "++++++++++++++++++++++
OnResume";
ditto

[henrika (OOO until Aug 14), 2016-03-18 10:16:03]

Thanks for quick review!

https://codereview.chromium.org/1816483002/diff/40001/media/audio/mac/audio_l...
File media/audio/mac/audio_low_latency_input_mac.cc (right):

https://codereview.chromium.org/1816483002/diff/40001/media/audio/mac/audio_l...
media/audio/mac/audio_low_latency_input_mac.cc:946:
properties.push_back(property);
On 2016/03/18 10:08:18, tommi-chromium wrote:
> you can do this in loop in 2 lines:
> 
> for (UInt32 i = 0; i < num_addresses; ++i)
>   properties.push_back(addresses[i].mSelector)

Done.

https://codereview.chromium.org/1816483002/diff/40001/media/audio/mac/audio_m...
File media/audio/mac/audio_manager_mac.cc (right):

https://codereview.chromium.org/1816483002/diff/40001/media/audio/mac/audio_m...
media/audio/mac/audio_manager_mac.cc:345: DVLOG(1) << "----------------------
OnSuspend";
Used it to make logging more easy to read. Now removed.

https://codereview.chromium.org/1816483002/diff/40001/media/audio/mac/audio_m...
media/audio/mac/audio_manager_mac.cc:351: DVLOG(1) << "++++++++++++++++++++++
OnResume";
On 2016/03/18 10:08:18, tommi-chromium wrote:
> ditto

Done.

[tommi (sloooow) - chröme, 2016-03-18 10:22:40]

lgtm

https://codereview.chromium.org/1816483002/diff/60001/media/audio/mac/audio_l...
File media/audio/mac/audio_low_latency_input_mac.cc (right):

https://codereview.chromium.org/1816483002/diff/60001/media/audio/mac/audio_l...
media/audio/mac/audio_low_latency_input_mac.cc:944: for (UInt32 i = 0; i <
num_addresses; ++i) {
nit: no {}

[henrika (OOO until Aug 14), 2016-03-18 10:26:34]

https://codereview.chromium.org/1816483002/diff/60001/media/audio/mac/audio_l...
File media/audio/mac/audio_low_latency_input_mac.cc (right):

https://codereview.chromium.org/1816483002/diff/60001/media/audio/mac/audio_l...
media/audio/mac/audio_low_latency_input_mac.cc:944: for (UInt32 i = 0; i <
num_addresses; ++i) {
On 2016/03/18 10:22:39, tommi-chromium wrote:
> nit: no {}

Done.

[henrika (OOO until Aug 14), 2016-03-18 10:26:40]

The CQ bit was checked by henrika@chromium.org

[commit-bot: I haz the power, 2016-03-18 10:26:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1816483002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1816483002/60001

[commit-bot: I haz the power, 2016-03-18 11:00:06]

Description was changed from

==========
Resolves crash in device notifier for audio input on Mac OS X

BUG=596000
==========

to

==========
Resolves crash in device notifier for audio input on Mac OS X

BUG=596000
==========

[commit-bot: I haz the power, 2016-03-18 11:00:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-18 11:01:44]

Description was changed from

==========
Resolves crash in device notifier for audio input on Mac OS X

BUG=596000
==========

to

==========
Resolves crash in device notifier for audio input on Mac OS X

BUG=596000

Committed: https://crrev.com/6d1646cef28a7d0bf51a1ddf1b6cf20161719799
Cr-Commit-Position: refs/heads/master@{#381931}
==========

[commit-bot: I haz the power, 2016-03-18 11:01:45]

Patchset 4 (id:??) landed as
https://crrev.com/6d1646cef28a7d0bf51a1ddf1b6cf20161719799
Cr-Commit-Position: refs/heads/master@{#381931}