Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1816463002: [heap] Fix skip list for deserialized code objects. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix skip list for deserialized code objects. R=hpayer@chromium.org Committed: https://crrev.com/b3a1adc6cc4c50310361862326544e7eb2cedcfc Cr-Commit-Position: refs/heads/master@{#34895}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : remove newline #

Patch Set 4 : fix #

Total comments: 1

Patch Set 5 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M src/heap/heap.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M src/heap/spaces.h View 1 2 3 4 2 chunks +13 lines, -3 lines 0 comments Download
M src/heap/spaces-inl.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M src/snapshot/deserializer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
Yang
4 years, 9 months ago (2016-03-18 06:25:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816463002/1
4 years, 9 months ago (2016-03-18 07:28:00 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/11828)
4 years, 9 months ago (2016-03-18 07:44:57 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816463002/20001
4 years, 9 months ago (2016-03-18 10:24:13 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816463002/40001
4 years, 9 months ago (2016-03-18 10:25:11 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/14017)
4 years, 9 months ago (2016-03-18 10:47:43 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816463002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816463002/60001
4 years, 9 months ago (2016-03-18 12:20:02 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 12:44:44 UTC) #15
Hannes Payer (out of office)
LGTM, one comment nit https://codereview.chromium.org/1816463002/diff/60001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1816463002/diff/60001/src/heap/spaces.h#newcode2051 src/heap/spaces.h:2051: // failure object if not. ...
4 years, 9 months ago (2016-03-18 12:54:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816463002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816463002/80001
4 years, 9 months ago (2016-03-18 14:34:34 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-18 14:57:17 UTC) #20
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 14:58:03 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b3a1adc6cc4c50310361862326544e7eb2cedcfc
Cr-Commit-Position: refs/heads/master@{#34895}

Powered by Google App Engine
This is Rietveld 408576698