Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1816423002: X87: [stubs] Split ToNumberStub into reusable subparts. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] Split ToNumberStub into reusable subparts. port b7aa4c3ab35b3a28fee7fc49bf7aa1003d66959e (r34922) original commit message: Split ToNumberStub into the entry ToNumberStub, and two new stubs, StringToNumberStub and NonNumberToNumberStub, which can be used when we already know something about the input (i.e. in various branches of the code stubs, or in TurboFan graphs). Also introduce an appropriate StringToNumber simplified operator for TurboFan, that is pure and is lowered to an invocation of the newly added StringToNumberStub. BUG= Committed: https://crrev.com/236d7005b6e72cac94259f45c95d4360c3cd4413 Cr-Commit-Position: refs/heads/master@{#34971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -13 lines) Patch
M src/x87/code-stubs-x87.cc View 2 chunks +30 lines, -13 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-22 03:41:11 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-22 03:44:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816423002/1
4 years, 9 months ago (2016-03-22 03:54:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 04:15:51 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 04:16:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/236d7005b6e72cac94259f45c95d4360c3cd4413
Cr-Commit-Position: refs/heads/master@{#34971}

Powered by Google App Engine
This is Rietveld 408576698