Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1816393002: Make line level profile ignore positions coming from inlined functions. (Closed)

Created:
4 years, 9 months ago by alph
Modified:
4 years, 9 months ago
Reviewers:
titzer, Sven Panne
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make line level profile ignore positions coming from inlined functions. BUG=590936 LOG=N Committed: https://crrev.com/4606211d5c3b120b5eb05808fd70c4253f2d7d76 Cr-Commit-Position: refs/heads/master@{#35040}

Patch Set 1 #

Total comments: 1

Patch Set 2 : 4 landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M src/profiler/cpu-profiler.cc View 1 1 chunk +15 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816393002/1
4 years, 9 months ago (2016-03-22 01:29:59 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 01:50:32 UTC) #4
alph
4 years, 9 months ago (2016-03-22 10:59:53 UTC) #6
alph
Ben, could you please take a look.
4 years, 9 months ago (2016-03-22 17:26:02 UTC) #8
titzer
lgtm https://codereview.chromium.org/1816393002/diff/1/src/profiler/cpu-profiler.cc File src/profiler/cpu-profiler.cc (right): https://codereview.chromium.org/1816393002/diff/1/src/profiler/cpu-profiler.cc#newcode284 src/profiler/cpu-profiler.cc:284: // FIXME(alph): in case of inlining the position ...
4 years, 9 months ago (2016-03-23 07:09:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816393002/20001
4 years, 9 months ago (2016-03-23 16:48:39 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 17:13:16 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 17:13:48 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4606211d5c3b120b5eb05808fd70c4253f2d7d76
Cr-Commit-Position: refs/heads/master@{#35040}

Powered by Google App Engine
This is Rietveld 408576698