Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1816383002: [remoting android] Update strings from UX review. (Closed)

Created:
4 years, 9 months ago by Lambros
Modified:
4 years, 8 months ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[remoting android] Update strings from UX review. Removed some periods. "setup" -> "set up". BUG=593842 Committed: https://crrev.com/522908673eb6d3e8b9db72eb024651493a5c3857 Cr-Commit-Position: refs/heads/master@{#383857}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Undo "Your computers" change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M remoting/resources/remoting_strings.grd View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Lambros
The "Your computers" change will also affect the web-app. Let me know if you want ...
4 years, 9 months ago (2016-03-22 01:27:24 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/1816383002/diff/1/remoting/resources/remoting_strings.grd File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/1816383002/diff/1/remoting/resources/remoting_strings.grd#newcode902 remoting/resources/remoting_strings.grd:902: Your computers This string is used in the webapp ...
4 years, 9 months ago (2016-03-22 05:00:24 UTC) #5
Lambros
https://codereview.chromium.org/1816383002/diff/1/remoting/resources/remoting_strings.grd File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/1816383002/diff/1/remoting/resources/remoting_strings.grd#newcode902 remoting/resources/remoting_strings.grd:902: Your computers On 2016/03/22 05:00:24, Sergey Ulanov wrote: > ...
4 years, 8 months ago (2016-03-29 00:48:56 UTC) #7
Sergey Ulanov
lgtm
4 years, 8 months ago (2016-03-29 01:03:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816383002/20001
4 years, 8 months ago (2016-03-29 21:57:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 23:16:47 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 23:18:15 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/522908673eb6d3e8b9db72eb024651493a5c3857
Cr-Commit-Position: refs/heads/master@{#383857}

Powered by Google App Engine
This is Rietveld 408576698