Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3636)

Unified Diff: components/resource_provider/resource_provider_apptest.cc

Issue 1816323002: Converts resource_provider apptests to unit tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add quit to delegate and remove dep Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/resource_provider/resource_provider_apptest.cc
diff --git a/components/resource_provider/resource_provider_apptest.cc b/components/resource_provider/resource_provider_apptest.cc
deleted file mode 100644
index a4c84adcb4133c7f599cdf861496414446381c8b..0000000000000000000000000000000000000000
--- a/components/resource_provider/resource_provider_apptest.cc
+++ /dev/null
@@ -1,95 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include <stddef.h>
-#include <stdint.h>
-
-#include "base/containers/scoped_ptr_hash_map.h"
-#include "base/files/file.h"
-#include "base/macros.h"
-#include "base/run_loop.h"
-#include "components/resource_provider/public/cpp/resource_loader.h"
-#include "components/resource_provider/public/interfaces/resource_provider.mojom.h"
-#include "mojo/common/common_type_converters.h"
-#include "mojo/platform_handle/platform_handle_functions.h"
-#include "mojo/public/cpp/bindings/array.h"
-#include "mojo/shell/public/cpp/application_test_base.h"
-
-namespace resource_provider {
-namespace {
-
-std::string ReadFile(base::File* file) {
- const size_t kBufferSize = 1 << 16;
- scoped_ptr<char[]> buffer(new char[kBufferSize]);
- const int read = file->ReadAtCurrentPos(buffer.get(), kBufferSize);
- if (read == -1)
- return std::string();
- return std::string(buffer.get(), read);
-}
-
-std::set<std::string> SetWithString(const std::string& contents) {
- std::set<std::string> result;
- result.insert(contents);
- return result;
-}
-
-std::set<std::string> SetWithStrings(const std::string& contents1,
- const std::string& contents2) {
- std::set<std::string> result;
- result.insert(contents1);
- result.insert(contents2);
- return result;
-}
-
-class ResourceProviderApplicationTest : public mojo::test::ApplicationTestBase {
- public:
- ResourceProviderApplicationTest() {}
- ~ResourceProviderApplicationTest() override {}
-
- protected:
- using ResourceContentsMap = std::map<std::string, std::string>;
-
- // Queries ResourceProvider for the specified resources, blocking until the
- // resources are returned. The return map maps from the path to the contents
- // of the file at the specified path.
- ResourceContentsMap GetResources(const std::set<std::string>& paths) {
- ResourceLoader loader(connector(), paths);
- loader.BlockUntilLoaded();
-
- // Load the contents of each of the handles.
- ResourceContentsMap results;
- for (auto& path : paths) {
- base::File file(loader.ReleaseFile(path));
- results[path] = ReadFile(&file);
- }
- return results;
- }
-
- // ApplicationTestBase:
- void SetUp() override {
- ApplicationTestBase::SetUp();
- }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(ResourceProviderApplicationTest);
-};
-
-TEST_F(ResourceProviderApplicationTest, FetchOneResource) {
- ResourceContentsMap results(GetResources(SetWithString("sample")));
- ASSERT_TRUE(results.count("sample") > 0u);
- EXPECT_EQ("test data\n", results["sample"]);
-}
-
-TEST_F(ResourceProviderApplicationTest, FetchTwoResources) {
- ResourceContentsMap results(
- GetResources(SetWithStrings("sample", "dir/sample2")));
- ASSERT_TRUE(results.count("sample") > 0u);
- EXPECT_EQ("test data\n", results["sample"]);
-
- ASSERT_TRUE(results.count("dir/sample2") > 0u);
- EXPECT_EQ("xxyy\n", results["dir/sample2"]);
-}
-
-} // namespace
-} // namespace resource_provider
« no previous file with comments | « components/resource_provider/apptest_manifest.json ('k') | components/resource_provider/resource_provider_test_app.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698