Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2626)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: android_webview/native/java_browser_view_renderer_helper.h

Issue 1816283005: Move SharedRendererState ownership to AwContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: All tests passing Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« android_webview/native/aw_contents.cc ('K') | « android_webview/native/aw_contents.cc ('k') | android_webview/native/java_browser_view_renderer_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/java_browser_view_renderer_helper.h
diff --git a/android_webview/native/java_browser_view_renderer_helper.h b/android_webview/native/java_browser_view_renderer_helper.h
index 874f008e2da21523303d0b4cfe95aab4c4545c6e..ed0e55f7929f5b473bc986deffcd5e0f43a8ca97 100644
--- a/android_webview/native/java_browser_view_renderer_helper.h
+++ b/android_webview/native/java_browser_view_renderer_helper.h
@@ -7,6 +7,7 @@
#include <jni.h>
+#include "base/android/scoped_java_ref.h"
#include "base/memory/scoped_ptr.h"
#include "skia/ext/refptr.h"
#include "ui/gfx/geometry/size.h"
@@ -20,7 +21,7 @@ namespace android_webview {
class SoftwareCanvasHolder {
public:
static scoped_ptr<SoftwareCanvasHolder> Create(
- jobject java_canvas,
+ const base::android::JavaRef<jobject>& java_canvas,
boliu 2016/03/30 16:12:13 unrelated change?
Tobias Sargeant 2016/03/30 17:17:17 Removed. Maybe should add a separate CL to get rid
const gfx::Vector2d& scroll_correction,
const gfx::Size& auxiliary_bitmap_size,
bool force_auxiliary_bitmap);
« android_webview/native/aw_contents.cc ('K') | « android_webview/native/aw_contents.cc ('k') | android_webview/native/java_browser_view_renderer_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698